amanda_like_it
20th November 2002 23:02 UTC

Feature Request - Common Data Block
This was mentioned in another thread but it was at the bottom and the topic had nothing to do with it so I thought I'd repost it in it's own thread.

I'm including a large branding image for both the installer and uninstaller, since it's loaded by both the installer and uninstaller NSIS puts it in the binary twice, making the file much larger. Any chance we could get some sort of common data block where we can put functions and files that are used with both the installer and uninstaller? This would help a lot.

Joost Verburg
20th November 2002 23:10 UTC

Maybe something like the datablock optimizer for both installer and uninstaller.

Datablock optimizations have the compiler check to see if any data being added to the data block is already in the data block, and if so, it is simply referenced as opposed to added (can save a little bit of size). It is highly recommended to leave this option on.

amanda_like_it
25th November 2002 03:07 UTC

Any news on this? My installer is 100k bigger than it needs to be because the branding image is in there twice. Is this something I can expect to see fixed in the future or should I stop waiting and try to work around this problem? :rolleyes:

Koen van de Sande
25th November 2002 13:00 UTC

I would remove the branding images from the uninstaller. If a user uninstalls a product, why should it look fancy? Just my opinion ;)

amanda_like_it
25th November 2002 13:05 UTC

Ah, well the problem is with the modern ui AddBrandingImage doesn't work properly. You have to add it to the modern.exe by editing dialog 105:1033, however this dialog is also used for the uninstaller. So with no branding image, there is a huge blank gap!

dselkirk
25th November 2002 13:48 UTC

just as another option, you can do a silent uninstall. simply display a yes\no msgbox asking them if they want to uninstall. then uninstall the files and display a completion msgbox. no dialogs are shown then, so no worries about including the graphic to the uninstall.

amanda_like_it
25th November 2002 14:05 UTC

I suppose that could work, but it does seem like a work around. Anyway I like that window that shows the log of what was removed. ;)