mikem4600
20th January 2003 17:00 UTC

Browse button bug?
I've been using NSIS for a while and I think I noticed a bug:

When I set the default install folder (with the InstallDir instruction) to something containing non-english characters, when I click the Browse button the default folder is added at the end of the location selected in the "Browse for folder" dialog, but a "square" character appears before each character (it looks like something's wrong with the unicode-to-ascii translation or something).

The problem appears even if I use the default (english) language for the installer. In the pic you can see the default text (the instruction was InstallDir "$PROGRAMFILES\ôåóô") and the text that appears when I select the C:\Games folder for installation using the Browse button. The problem doesn't appear if I type the path manually.

kichik
20th January 2003 17:17 UTC

Confirmed. Will be fixed.

kichik
21st January 2003 20:38 UTC

I have looked into this bug again and it appears to be another old aged bug. It was there at least since 1.98 (I haven't tested any further).

I have fixed this in the latest CVS version. I have also uploaded a compiled version.

mikem4600
23rd January 2003 08:24 UTC

Latest version works perfectly! Great work! :up:

resonant
29th April 2003 18:12 UTC

Hi!
If detection of an install location fails (non-existent or changing app-paths, regkeys, etc), a user may need to browse for the install location manually. However, if InstallDir is set (i.e. $PROGRAMFILES\quake3) and the user goes to find c:\program files\quake3 with the browse function, the installer tacks on another quake3 at the end (e.g. c:\program files\quake3\quake3). Is there a way to prevent this?

Sincerely,
Ty

kichik
29th April 2003 18:21 UTC

If the last part of the path is equal to what NSIS wants to add it won't add it. In what version are you experiencing this problem?

resonant
29th April 2003 18:39 UTC

Hi! My tests show you're right! :) So I suppose I picked a bad example (quake3\quake3).

My intention is such that if a user browses for an install directory, this should be the base directory into which files should be installed. So if $InstDir is set and the user browses instead to c:\program files\QuakeNBake, the installer shouldn't make it "c:\program files\QuakeNBake\quake3"

Is there a way around this?

Sincerely,
Ty

kichik
29th April 2003 18:47 UTC

Use InstallDir $PROGRAMFILES\quake3\

resonant
29th April 2003 21:02 UTC

sweet & holy rock & roll, baby.

Sincerely,
ty