Modern UI 1.65 - NSIS Forums

Joost Verburg
25th May 2003 21:20 UTC

Modern UI 1.65
I have just uploaded a new version of the Modern UI.

The main difference is that there is no difference custom page system anymore, you just insert page macro's and can insert custom pages between them:

!insertmacro MUI_PAGE_LICENSE
Page custom CustomPageA
!insertmacro MUI_PAGE_COMPONENTS
Page custom CustomPageB
!insertmacro MUI_PAGE_DIRECTORY
Page custom CustomPageC
!insertmacro MUI_PAGE_INSTFILES

!insertmacro MUI_UNPAGE_CONFIRM
!insertmacro MUI_UNPAGE_INSTFILES

So you will have to make this small change in your script, but I think it's worth it :D

deguix
25th May 2003 22:03 UTC

Now the confusion is eliminated! Because sometimes I thought that the old macros ordered pages, and got wrong pages order!

Afrow UK
25th May 2003 22:37 UTC

It would be nice if you could make a macro for custom pages, which included the header text in it.

e.g.
!insertmacro MUI_CUSTOM_PAGE "CustomPage" "" " - Hello!" "This is a custom page" " Yes, it really is a custom page!"

I doubt that that is possible without using up the custom page's pre function ("CustomPage").

-Stu

Joost Verburg
25th May 2003 22:57 UTC

That's not possible. You have to use the pre function.

Joel
25th May 2003 23:30 UTC

sounds nice to me...
And the others, like "!define MUI_LICENSEPAGE",
can be eliminated?

Joost Verburg
26th May 2003 14:25 UTC

Yes, you only have to insert these page macro's. If you are using custom pages, just insert them between the macro's.

You don't need the defines anymore.

Vytautas
27th May 2003 01:07 UTC

Problem
I have a little problem with the new version of Modern UI.

I had the installer show 2 directory pages using this code:


  !insertmacro MUI_PAGECOMMAND_DIRECTORY
  !insertmacro MUI_PAGECOMMAND_DIRECTORY

In the new version I had to modify the code:


  !insertmacro MUI_PAGE_DIRECTORY
  !insertmacro MUI_PAGE_DIRECTORY

However when compiling it shows this error:


!define: "MUI_DIRECTORYPAGE" already defined!
Error in macro MUI_PAGE_DIRECTORY on macroline 6

Could anyone explain how I could get that function back?

Vytautas

Vytautas
27th May 2003 01:40 UTC

I've figured out a (temporary) solution, but if there is a nicer way of doing this I would appreciate it.


!insertmacro MUI_PAGE_DIRECTORY
Page directory mui.DirectoryPre mui.DirectoryShow mui.DirectoryLeave "MUI_INSTALLBUTTON_DIRECTORY"

Vytautas

CodeSquid
27th May 2003 11:19 UTC

Problem with MUI_LICENSEBKCOLOR
There's a slight problem with MUI_LICENSEBKCOLOR which is set to /windows by default.
It is windows standard, that a read-only textbox is greyed-out.
But if MUI_LICENSEBKCOLOR is defined to /windows, the license text background is pure white where it is supposed to be grey.
Please change it that the license text background is greyed out by default to keep ui standard conformance.

kichik
27th May 2003 11:34 UTC

You can define MUI_LICENSEBKCOLOR to /grey to get the old behavior back. According to Joost white is the standard for licenses.

Joost Verburg
27th May 2003 15:59 UTC

Most modern installer use a white background for the license, because that is easier to read (like MS Office etc.).

Vytautas: I'll fix that issue.

CodeSquid
27th May 2003 17:10 UTC

Originally posted by kichik
You can define MUI_LICENSEBKCOLOR to /grey to get the old behavior back. According to Joost white is the standard for licenses.

Thanks for pointing that out. A little bit documentation about it would be good, though

kichik
27th May 2003 17:12 UTC

The documentation writer will be back soon.

rpetges
27th May 2003 20:59 UTC

Hi Joost,

I like the new macro system for inserting custom pages, but why did you change the names for all pages (MUI_LICENSEPAGE to MUI_PAGE _LICENSE). On the other hand, you left the old names for the defines, for example MUI_LICENSEPAGE_CHECKBOX to display a checkbox on the license page .... a little bit confusing.

Maybe it would be a good idea to name the Defines similar to the pages they belong ?

Romain

Joost Verburg
27th May 2003 22:01 UTC

I prefer the new names for the macro's. The old macro's for pages (custom page commands) also had a name like these.

I think the current define names are OK, MUI_PAGE_NAME is for a page, MUI_OBJECT_SETTING for a define.

rpetges
27th May 2003 22:23 UTC

I think the current define names are OK, MUI_PAGE_NAME is for a page, MUI_OBJECT_SETTING for a define. [/B]

OK, but maybe you should rename the define to something that corresponds to the page:

Why is the page called MUI_PAGE_LICENSE and the define MUI_LICENSEPAGE_CHECKBOX ... wouldn't it be more logical to use MUI_PAGELICENSE_CHECKBOX ? ... just an idea

Brummelchen
28th May 2003 00:10 UTC

> Modern UI 1.65
Where to dl' ?

Thx

Vytautas
28th May 2003 04:23 UTC

Brummelchen just update NSIS to the newest CSV ;)

Vytautas

Brummelchen
28th May 2003 08:47 UTC

In that case i get erros on my actual project - i dl' it yesterday morning.

Thx.

Joost Verburg
29th May 2003 20:36 UTC

You have to make some small changes, check the first post.