brad_h
10th June 2003 01:18 UTC

Version info
Hi!

The new version info feature is great, but being the pedantic person that I am, I thought I'd point out a few things:

* I can't put certain ASCII chars in any of the entries. E.g. try and put a "©" into VILegalCopyrights, and it displays one of those boxes in place of that char.
* It'd be great if you could add a command to change the language/code page.
* Also, is it possible to add your own custom entries into the version info? The changelog entry for this feature eludes to this, but how do you enable this exactly?
* VIProductVersion puts in a "Product Version" entry, and a "File Version" entry in as well, and there's no way to specify each individually. (I like to specify the "FileVersion" in the "StringFileInfo" block of the VS_VERSION_INFO resource, so I don't have to conform to the "x.x.x.x" format.)
* Have a command that lets you specify the internal name, and if you don't use that command, the internal name won't appear?

I'm probably just rambling, but above issues may be of interest.

Regards,
Brad. :eek:

ramon18
10th June 2003 02:46 UTC

Hi,

the problem with some chars like ©, is fixed now, maybe uploaded tomorrow,

I don't know if this is a good idea, but we can add some function to add pairs of Key=Value, and the user is responsible to add all necessary keys, this is maybe the best solution to avoid the need to add new commands every day :)

Language/code_page can be added, but the idea was to automatically add all the pairs of Language/code_page based on the languages used inside installer, but thats ok, it's better idea give full control to the scripter :)

bye
Ramon

brad_h
10th June 2003 06:44 UTC

Thanks, Ramon! Much appreciated!

Joel
10th June 2003 16:49 UTC

Language/code_page can be added, but the idea was to automatically add all the pairs of Language/code_page based on the languages used inside installer, but thats ok, it's better idea give full control to the scripter :)

ramon18
10th June 2003 16:57 UTC

Lobo maybee you can do enhancement version of MakeLangID.exe with support to codepages?

BR,
Ramon

Joel
10th June 2003 17:10 UTC

Well I don't know that much of C++ :(

[edit]
But I can create a self-viewer of that codepage generator
[/edit]

ramon18
10th June 2003 17:13 UTC

In this case you can make just a little html file with script to do the task :)

Joel
10th June 2003 17:57 UTC

Sure...I'll send you a PM to talk this over...
:)

veekee
11th June 2003 19:57 UTC

Hi,

The IsValidCodePage function (from ResourceVersionInfo.cpp file) is comparing the user entry to all values from an array. The problem is that the array is incomplete (1033 (English US or 1036 (French Fr) for example) ! I hope that 'bug' could be corrected :) !

Regards

Julien

veekee
11th June 2003 20:04 UTC

** oups : wrong message ! Please delete it :rolleyes: sorrrrrrrry :cry: **

kichik
11th June 2003 20:05 UTC

Well, actually, 1036 and 1033 are not code pages, they are language ids. Hebrew code page for example is 1255, while its language id is 1037.

veekee
11th June 2003 20:08 UTC

yes, my mind has suddently awaken and my last post makes me dumber than ever :(

veekee
11th June 2003 20:10 UTC

... instead of looking for invisible bugs, i should thanks the author for that great new feature :)

kichik
12th June 2003 14:02 UTC

That would be Ramon ;)