Archive: Can Abort from MUI Pre fn, but not from MUI Leave fn


Can Abort from MUI Pre fn, but not from MUI Leave fn
I am using latest CVS, updated yesterday. This is using Win98SE with latest updates.

According to the documentation, chapter 4...
Callbacks. Use Abort from a built-in page's pre-function to skip the page, and from a built-in page's leave-function to stay in the page.

Test Results: I tried using abort from the StartMenu's pre function, and it worked as documented above. But it does not work as documented above when used in the StartMenu's leave function. My code is shown below.

Problem. Below I am using Abort in the leave-function, it gives the error message, so it is seeing the Abort command but it DOES NOT stay in the page as the documentation (see above) says it should. Instead, it moves on to the next page. Method 2 (see below) doesn't work either.

I add the following code to the StartMenu.nsi, compile and test.

!define MUI_CUSTOMFUNCTION_STARTMENU_LEAVE StartMenuPage_Leave

Method 1.

Function StartMenuPage_Leave
StrCmp ${MUI_STARTMENUPAGE_VARIABLE} "${MUI_PRODUCT}" PathGood
MessageBox MB_OK|MB_ICONSTOP "Please correct. This path must end with: \${MUI_PRODUCT}"
Abort
PathGood:
FunctionEnd


Method 2.

Function StartMenuPage_Leave
StrCmp ${MUI_STARTMENUPAGE_VARIABLE} "${MUI_PRODUCT}" PathGood
Abort "Please correct. This path must end with: \${MUI_PRODUCT}"
PathGood:
FunctionEnd


Is this a bug, or a feature that's not finished yet?
If I should post this as a bug report, please advise.

Thanks,
Lilla


Thanks for reporting this issue :D Fixed and uploaded :)

Note that it might take up to 24 hours before public CVS will be updated (because of SF CVS server issues).


Wow! fast fix!

Thank you,
Lilla