Small feature request :-)

dabossuk
11th August 2003 15:47 UTC

Small feature request :-)
Hi

On the makensisw.exe app - could you add under the "File menu item" the last 5 scripts you loaded into the compiler!

I work on a number of scripts and would cool to just select the last one I was working with ;-)

Thanks, and hope you have a good holiday!

DabossUK

Joel
11th August 2003 16:30 UTC

A cool feature that will help...
did you add it in the Nsis dev list?

iceman_k
12th August 2003 18:51 UTC

Done.
Please get the latest CVS version for this functionality.

rainwater
13th August 2003 06:52 UTC

Originally posted by iceman_k
Done.
Please get the latest CVS version for this functionality.

It doesn't work for me. I have a menu item like this:


/X"SetCompressor bzip2" "C:\test files\file.nsi

And it obviously fails when trying to run it. Also, it should only show the filename, not the path. If it's going to show the path, there should be some truncation to the beginning so my menu item isn't longer than the makensisw window itself.

Also, there should be a way to clear the MRU list. And files that no longer exist should be removed if you try to run it (and the file doesn't exist).

iceman_k
13th August 2003 14:35 UTC

It doesn't work for me. I have a menu item like this:
/X"SetCompressor bzip2" "C:\test files\file.nsi
And it obviously fails when trying to run it.

This will be fixed.

Also, it should only show the filename, not the path. If it's going to show the path, there should be some truncation to the beginning so my menu item isn't longer than the makensisw window itself.

Good point.

Also, there should be a way to clear the MRU list.

I agree.

And files that no longer exist should be removed if you try to run it (and the file doesn't exist).

This is not really standard Windows GUI behavior (check out MS Word, MS Excel, Visual Studio, etc.
But it would be useful, no doubt.

Afrow UK
13th August 2003 14:39 UTC

Office XP clears the recent files area if the files do not exist (on user click).

-Stu

iceman_k
13th August 2003 15:00 UTC

Office 2000 does not- I guess they fixed it in Office XP.

rainwater
13th August 2003 15:26 UTC

Originally posted by iceman_k
This is not really standard Windows GUI behavior (check out MS Word, MS Excel, Visual Studio, etc.
But it would be useful, no doubt.

That's fine. I can live without this feature. I have seen it in several apps, but as long is there is a clear option, it will be fine not to have it.

iceman_k
13th August 2003 17:11 UTC

OK, get the latest CVS version and give it another try.
Let me know if you find any more bugs. PM'ing me is probably the best way to do this.

[edit]The Clear option is under the Tools menu.[/edit]

rainwater
14th August 2003 02:21 UTC

Works much better now. My only issue now is that it doesn't remember my compressor settings (or any /X parameters passed really). For certain installers, I have to use bzip2, so the MRU doesn't work since NSIS defaults to zlib.

iceman_k
14th August 2003 02:46 UTC

Remembering compressor settings was a feature request that has been shelved for now.
The basic support for this feature is already there in the GUI, but it is waiting on a compressor command line option in makensis.
Using /X"SetCompressor foo" will work most of the time, but if you explicitly set the compressor in your script, it will override the command line option.
If you know which installers need bzip2, why not add the SetCompressor bzip2 command directly to the scripts?

rainwater
14th August 2003 16:44 UTC

Originally posted by iceman_k
If you know which installers need bzip2, why not add the SetCompressor bzip2 command directly to the scripts?

Because right now it crashes when using bzip2 :) Kichik is fixing the problem now though.

dabossuk
15th August 2003 11:27 UTC

Hi

Just wanted to say thanks for doing this! - has saved sooo much clicking around ;-)

iceman_k
18th August 2003 06:00 UTC

You're welcome.
That's what we're here for.
Please let me know if you run into any bugs with this feature.

pengyou
22nd August 2003 13:25 UTC

The new MRU feature does not work on my Win98SE system. I am using MAKENSISW.EXE v1.102 from a snapshot downloaded yesterday (21 August). After editing several files, the MRU list remains empty (see screenshot). I have exited and rerun the program but it never shows any MRU entries.

When I looked at the registry, I found some MRU data in HKLM\Software\NSIS\MRU (entries 0, 1, 2, 3 and 4 had the expected data).

iceman_k
22nd August 2003 13:58 UTC

Unfortunately I don't have a Win98SE system to test on.
However, I will review all the API I use to check for OS compatability.

iceman_k
23rd August 2003 05:33 UTC

Well, I finally had to setup VirtualPC with a Windows 98 SE VM to be able to test this. It turns out that MS Windows 9x handles the WM_MENUSELECT message differently from MS Windows NT/2000/XP.
(Why am I not surprised? Its Micro$oft after all).
So I had to overhaul quite a bit of code to get it working.
Anyway, the latest CVS version should now work with Windows 9x as well as Windows NT/2000/XP.
As always, please let me know if you find bugs in the implementation.

pengyou
23rd August 2003 14:05 UTC

Downloaded the 23 August (07:44 GMT) CVS snapshot and found that the MRU list now works perfectly on my Win98SE system. Thanks for fixing it so quickly.