Bugs in NSIS - NSIS Forums

deguix
30th October 2003 21:24 UTC

Bugs in NSIS
I found 2 bugs in NSIS in this week:

Using:
Windows 95 (without much of the updates, no internet)
Using latest development snapshot

1) DeleteINISec command: doesn't return a error when a section doesn't exist.

I put a IfErrors 0 "Loop" command after it, and never executed the code after the IfErrors (see the 0?) (it is in a loop part (using IntOp $1 $1 + 1, adding everytime), only exits when detect a error, but this is the problem).

2) Banner Plugin: doesn't work after calling Install Options.

It stops the program and I only can quit it using Ctrl+Alt+Del. Used just one time (to call it).

kichik
31st October 2003 23:02 UTC

Please attach the script for testing.

deguix
1st November 2003 20:57 UTC

I can't do it now, only tomorrow. I have to go to my computer and get the information.

kichik
1st November 2003 21:26 UTC

On both Wine and Windows XP the error flag is not set if the section was not deleted. You will need to find anther method to figure if the section is there or not. A constant key that will show in all of them should do the trick.

Documentation fixed.

deguix
2nd November 2003 20:58 UTC

1) Thanks!

2) I forgot the script, I didn't get time to use my computer yesterday and today.

deguix
3rd November 2003 21:53 UTC

This script is a part of my program. This RCTribes.nsh have the RCDefault.nsh (the start part of script). Use external file language strings and external search for tribes.... I will try to get a simpler script (like my last post, I don't have much time, so all go in "s l o w m o t i o n").

kichik
5th November 2003 20:13 UTC

Why are you using /NOUNLOAD for Banner::Destroy? It will not unload this way.

You are using a special build of InstallOptions. Unless it happens with the official build too, you should ask whoever built your InstallOptions. In this case, dselkirk.

deguix
5th November 2003 22:03 UTC

Why are you using /NOUNLOAD for Banner: destroy? It will not unload this way.

I will have a look in this.

You are using a special build of InstallOptions....

I used too the original one, and gave the same thing. As I wrote above, I will try do the /UNLOAD thing first.

Maybe someone have to update the examples of plugins come with NSIS. They have the old "Icons" folder, that is now the "Graphics" folder. About ALL of the examples relationated with graphics have the problem (AdvSplash, BgImage...).

Joost Verburg
6th November 2003 13:01 UTC

Fixed those Graphics filenames.

deguix
17th November 2003 22:15 UTC

Now I'm more able to describe this:

First, this bug "aparently" occurs only in Win95 (my program was based in the Win98 SE, now I have a Win95, this occured in the first compilation in Win95).

Second, it only occurs when using Modern UI.

Third, this bug not occurs in Callback functions (like .onInit), but with custom pages (not tested using common pages, nor the section itself).

Fourth, it isn't linked with Install Options, nor the modification of it, (I tried to call BEFORE calling it, and gave this bug).

----------------------------------------------------------------------

Off of this Banner Plugin bug, EnumRegEnumRegKey and EnumRegValue apparently doesn't work in Win95, is it real? I will test it more, because the last time I tested this was before the installation of lots of Win 95 updates.

ramon18
18th November 2003 09:20 UTC

Hi deguix,

could you please submit a simpler script focusing only the bugs you found?

sorry but this thread is somehow confusing me :/

TIA,
Ramon

deguix
18th November 2003 15:09 UTC

I will do it today at night.