Archive: Bug/typo in License screen of Modern UI


Bug/typo in License screen of Modern UI
In the license screen of the Modern UI interface, it says "If you accept the terms of the agreement, select the first option below. You must accept the agreement to install $(^Name). Click Next to continue"

There is no next button. It appears it's getting/using the "MUI_INNERTEXT_LICENSE_BOTTOM_RADIOBUTTONS" string instead of the "MUI_INNERTEXT_LICENSE_BOTTOM" string. This exhibits itself in the MultiLanguage.nsi example file. I'm using the "Latest Development Version" from the webpage (not CVS), I apologize if this has already been fixed.


Which type of License page do you use?

Vytautas


I did not specify (don't know how, in fact!). I'm simply using the Modern Language/MultiLanguage.nsi example as my base - its text is wrong as well.


Yes you are right although I think it might only affect certain languages only, like English, as I tested it with Lithuanian and it was OK.

Vytautas


If nothing else the "Click Next to continue" needs to get fixed. On the otherhand, for a work-around, anyone know how I can explictly tell it to use the Radio button style, or the default style?


Check out the MUI Readme file. The section on license page settings will show you how to either change the type of the license page and/or manually modify the text.

Vytautas


Heh, I swear I looked though there, and didn't see it... but now I see the section. Looks like there's no way to excplitly tell it to not use the radio button mode... looks like the problem might be around line 665 in my Mui/System.nsh:


!ifdef MUI_LICENSEPAGE_CHECKBOX & MUI_LICENSEPAGE_RADIOBUTTONS
LicenseText "$(MUI_${MUI_PAGE_UNINSTALLER_PREFIX}INNERTEXT_LICENSE_BOTTOM)" "${MUI_LICENSEPAGE_BUTTON}"
!else ifdef MUI_LICENSEPAGE_CHECKBOX
LicenseText "$(MUI_${MUI_PAGE_UNINSTALLER_PREFIX}INNERTEXT_LICENSE_BOTTOM_CHECKBOX)" "${MUI_LICENSEPAGE_BUTTON}"
!else
LicenseText "$(MUI_${MUI_PAGE_UNINSTALLER_PREFIX}INNERTEXT_LICENSE_BOTTOM_RADIOBUTTONS)" "${MUI_LICENSEPAGE_BUTTON}"
!endif


I'd assume that first line is supposed to be a !ifndef... then things would work like they should, I'd assume.

Yes you are right if you change that line it does work as expected. Obviousely a typo one of the NSIS Devs made during the latest changes.

Vytautas


Thanks, fixed.