- NSIS Discussion
- Path Manipulation
Archive: Path Manipulation
cosmic66
29th November 2003 13:55 UTC
Path Manipulation
I'm using these functions for path manipulation
(thanks, KiCHiK :-)):
I would like to add a function that will first check if a specific
string is already defined in PATH, so it wouldn't add it again
(the string I add is always: "%FOO%\bin").
Can anyone help me on how to do that?
And when I use un.RemoveFromPath to remove a string from PATH, it
leaves the semi-colon that it added in front of it in the PATH string.
Is that done on purpose and is it not such a good idea to remove
that one?
Thanks!
kichik
29th November 2003 14:09 UTC
The function checks if the directory is already there and doesn't add it if it is. If you want to check yourself anyway, simply read %PATH% using ReadEnvStr and only call the function if it's not there.
The semicolon is not on purpose, but it doesn't really hurt. It's just an empty path that will be ignored. There is also this issue which I should finally fix sometime...
kichik
29th November 2003 17:33 UTC
Fixed.
cosmic66
30th November 2003 14:50 UTC
Thanks for your fix!
One more question regarding the path manipulation:
I add my path to PATH like so:
Push "$INSTDIR\bin"
Call AddToPath
And I remove it in the uninstaller like so:
Push "$INSTDIR\bin"
Call un.RemoveFromPath
If I run the installer twice (with the same INSTDIR) it will add
the same path to PATH twice.
From how I understood your answer it shouldn't do that, should it?
kichik
30th November 2003 16:06 UTC
I was wrong, it doesn't check if the path is already there. You should check for it yourself using ReadEnvStr and the StrStr function.
cosmic66
30th November 2003 21:28 UTC
How do I get the PATH string for Windows 9x?
Joost Verburg
30th November 2003 21:33 UTC
Use ReadEnvStr.
cosmic66
11th December 2003 11:20 UTC
Hi,
I'm having problems with checking PATH for a string.
I just can't find the mistake, maybe someone can
help me?
The problem is when adding the string to PATH (AddToPath),
I first would like to check if the string is already there.
But the string is never found (StrStr always returns
-1), although in there.
I have attached my modified PathManipulation script.
Thanks,
Barbara
kichik
11th December 2003 13:38 UTC
There is an example of checking on the archive page now. Try it and let me know if it works for you.
cosmic66
11th December 2003 16:00 UTC
Thanks for the example, with your code I got it to work!
I had another problem then which was that I'm writing and testing
the installer without the actually data (those commands are added
through scripts that I don't have access to yet) and thus
$INSTDIR\bin was not created through my test installation.
If you then call:
GetFullPathName /SHORT $1 $1
(where $1 is "$INSTDIR\bin" and the path doesn't exist, the error
flag is set and $1 is empty.
For completenes, this is the code that works for me now:
ReadEnvStr $0 path
Push "$0;"
Push "$INSTDIR\bin;"
Call StrStr
Pop $2
IntCmp $2 -1 addPath addPath
StrCpy $1 "$INSTDIR\bin"
GetFullPathName /SHORT $1 $1
MessageBox MB_OK $1
ReadEnvStr $0 path
Push "$0;"
Push "$1;"
Call StrStr
Pop $2
IntCmp $2 -1 addPath addPath dontAdd
cosmic66
16th December 2003 12:50 UTC
I have one remaining problem:
I'm testing for a string in PATH as posted abough.
If INSTDIR consists of spaces (such as "MyApp 2"), the
string is not detected and added to PATH again.
What can I do to solve this?
kichik
16th December 2003 12:52 UTC
Use the updated functions, they check it for, spaces or no spaces.
cosmic66
16th December 2003 13:40 UTC
I have now updated the functions (from your archive page).
If the installdir has spaces it works OK now.
On uninstallation it messes up the PATH string though:
The first entry on my box was:
C:\Program Files\Microsoft Visual ...
and after I uninstalled my SW my path was still in there but
the start of the string was shortened to:
\Microsoft Visual ...
kichik
16th December 2003 15:21 UTC
Fixed, thanks.
Thalion77
6th April 2006 09:41 UTC
Where is the archive page? I would like to download the functions to manipulate the path variable.