kichik
7th June 2005 20:08 UTC

Thanks, fixed.

Anders
26th June 2005 21:15 UTC

4.8.1.21 InstallDir:
"Sets the default installation directory is." remove is (doh)

kichik
28th June 2005 20:18 UTC

Thanks, fixed.

BioDuo
30th June 2005 12:23 UTC

4.9.14.5 FindWindow

FIndWindow $0 "my window class" "my window title"
It should be Findwindow

glory_man
30th June 2005 14:34 UTC

4.9.14.1 BringToFront
... If the user if working with another ...

I think it should be - If the user is working

kichik
30th June 2005 18:17 UTC

Thanks, fixed.

Anders
30th June 2005 19:06 UTC

4.7.2.1.6 .onMouseOverSection
STR: prefix is missing from lparam (in example code)

the docs also needs to be more clear about the description label, eg you actually have to use resource hacker to add a label (or use a existing label like in the ugly hack i did here: http://www.rafb.net/paste/results/XTG9Pd58.html )

kichik
30th June 2005 19:16 UTC

Thanks, fixed.

glory_man
30th June 2005 19:16 UTC

And what about

Variables

Variables start with $. User variables should be declared and are case-sensitive.

var vv1
...
StrCpy $Vv1 "1 string 1"
MessageBox MB_OK "$vV1"

kichik
30th June 2005 20:52 UTC

Just a relic from the old days when variables were case sensitive. Fixed, thanks.

Afrow UK
16th July 2005 16:06 UTC

This isn't really an issue with the manual, but I noticed that there's no shortcut to the InstallOptions manual in the start menu shortcuts group.
Or is it just me?

-Stu

kichik
16th July 2005 16:29 UTC

Thanks, fixed.

Comm@nder21
14th September 2005 19:55 UTC

file:
INSTALL

This is a trimmed version of Appendix F of the documentation.

DrO
14th September 2005 20:20 UTC

Appedix? ;)

-daz

Afrow UK
15th September 2005 19:06 UTC

In the modern UI readme, under 3. Pages > Page Settings > Finish Page Settings > MUI_FINISHPAGE_RUN_FUNCTION:

Call a function instead of executing an application (define MUI_FINISHPAGE_RUN without parameters). You can use the function to exectute multiple applications or you can change the checkbox name and use it for other things.

-Stu

Comm@nder21
15th September 2005 19:25 UTC

Appedix?

kichik
15th September 2005 19:36 UTC

Thanks, fixed.

Jamyn
16th September 2005 00:50 UTC

Typos
I've attached the typos I found. Hope it helps.

-J

Jamyn
16th September 2005 10:43 UTC

Diff File
Oops, I just saw the message on the first page of this thread that asks for large corrections to be presented as a patch. I can't edit my post above to delete it, but anyway...

I have attached a diff to this message, with all the corrections listed in the above message, plus one or two others I ran across. I'm not sure if the way I did it is the preferred way, but if not - just let me know and I'll change it.

I attached it as .txt because the forum doesn't allow the .diff extension. Thanks,

-J

kichik
16th September 2005 12:26 UTC

Awesome, thanks! All committed.

o_owd
18th September 2005 09:37 UTC

in the Install Options readme,

(NSIS\Docs\InstallOptions\Readme.html)
"Call the DLL
You can call InstallOptions in a page function, check the NSIS documentation for information about the page system."

the link "NSIS documentation" points to "file:///C:/Program%20Files/NSIS/Docs/Chapter4.html#4.5"
the file does not exist.

OJi.

kichik
20th September 2005 18:13 UTC

Thanks, fixed.

Jnuw
22nd September 2005 18:46 UTC

This is not a typo, but a suggestion for clarity. Under the 4.9.1.5 File section, on the /nonfatal bullet, it currently states:

"If the /nonfatal switch is used and no files are found, a warning will be issued instead of an error."

I think it would be good to add that if the /nonfatal switch is activate or invoked (no files found), the line will no longer be a run-time instruction, and Relative Jumps will not see the line (per jump info below). It would be best to use regular labels around File /nonfatal commands to be safe.

"4.4 Relative jump of +2 will skip one instruction and go to the second instruction from the current instruction...An instruction is every command that is executed at run-time, when the installer is running. MessageBox, Goto, GetDLLVersion, FileRead, SetShellVarContext are all instructions. AddSize, Section, SectionGroup, SectionEnd, SetOverwrite (and everything under Compiler Flags), Name, SetFont, LangString, are not instructions because they are executed at compile time."

Thanks for your time!

kichik
22nd September 2005 19:04 UTC

That's a bug, not a documentation problem. Please submit a bug report.

Jnuw
22nd September 2005 21:26 UTC

Logged as a bug, 1299100. Thanks for looking at this, and your help on my 2.09 questions from a few minutes ago.

Jnuw

Afrow UK
26th September 2005 18:47 UTC

Idea
I know that in the history of NSIS we've always had the "NSIS Examples Directory" shortcut, but I think a "NSIS Directory" shortcut would be more helpful as I myself have my projects in a Projects sub-folder.

-Stu

kichik
27th September 2005 22:33 UTC

I don't think that's necessary. The start menu is meant for a quick start and that folder contains nothing that's not already linked. In your case, I think you'd even do better with a direct link to that projects folder.

Anders
6th November 2005 17:32 UTC

4.6.1.5 SectionGroup

[/e] Caption [section_group_name index_output]

should be

[/e] section_group_name [index_output]

JasonFriday13
8th November 2005 07:11 UTC

I found a few typos:

4.8.2.3
Typically the SetCompress flag will effect the commands after it,
should be 'affect'.

Also found that this code changes the compression status:
SetCompress off
SetCompressor lzma

Setcompressor switches SetCompress back to the default compression status (auto). This should be documented or bugfixed.

5.4
!define symbol1 ${symbol2}
After copying and pasting the code, I found that this typo has a 1 after symbol. I thought it was two l's. Maybe it should be changed to symbol_1 and symbol_2 or somthing similar (for clarity).

B2
To ask the user for a reboot if required,
should be 'To ask the user for a reboot, if required,' or 'If required, you can ask the user for a reboot.'

D2
For Windows NT (NT4/2000/XP), it's also possible to create the key in the HKCU hive,
Should this be hive, or should it be changed to folder/directory?

kichik
8th November 2005 19:53 UTC

Thanks, fixed.

SetCompress off followed by SetCompressor worked fine for me. Please include a complete example.

It should indeed be HKCU hive. That's how the registry objects are called [MSDN].

JasonFriday13
9th November 2005 04:01 UTC

My bad on SetCompressor. It does work. Maybe instead of saying 'Using lzma compression', it could say 'Using no compression', because I look at this line when I compile my installers with SetCompress off, and I think 'Oh, it's using lzma compression' when it is really not compressed.

glory_man
30th November 2005 16:43 UTC

From MUI doc:

...
Language Selection Dialog Settings

To remember to users preference, you can define a registry key.
...

To remember the...

guest1298
1st December 2005 04:52 UTC

4.9.13.1 SectionSetFlags

... The first bit (lowest) represents whether the section is currently enabled,

kichik
2nd December 2005 12:05 UTC

Thanks, fixed.

Wladimir Mutel
5th December 2005 13:35 UTC

In section 4.9.14.2, CreateFont :

GetDlgItem $$0 $HWNDPARENT 1

Should there really be two '$' signs ?
And if yes, then why ?

Comm@nder21
5th December 2005 13:47 UTC

nope there should not, its definetly a typo.

kichik
6th December 2005 21:02 UTC

Thanks, fixed.

{_trueparuex^}
9th January 2006 11:35 UTC

foul language
In section 4.8.1.30, Name :
'CrapSoft MyApp'
==> 'MySoft MyApp'

In section C.1, Get parent directory :
; input, top of stack (e.g. C:\Program Files\Poop)
==> ; input, top of stack (e.g. C:\Program Files\foo)

{_trueparuex^}
9th January 2006 11:56 UTC

Aannd there was also some poo in the examples.

In these files:
Examples\bigtest.nsi
Examples\InstallOptions\test.ini
Examples\InstallOptions\testnotify.ini

(Not sure if the bigtest.nsi needs fixin)
StrCpy $1 "POOOOOOOOOOOP"
==> StrCpy $1 "FOOOOOOOOOOOO"

Heres a patch anyway.

iceman_k
9th February 2006 22:24 UTC

Not actually a typo, but missing documentation. The LockWindow command is supported but not documented anywhere.
What exactly does it do? I am guessing it enables or prevents window repainting.
Why would it be needed in an installer? I am not quite sure.