Archive: HELP! !define: "MUI_TEXT_WELCOME_INFO_TEXT" already defined!


HELP! !define: "MUI_TEXT_WELCOME_INFO_TEXT" already defined!
Hi all,

According to the docs and what I've seen in this forum, if I want to replace one text string in a language file I should just be able to !define the string before calling !insertmacro MUI_LANGUAGE. Well, it isn't working. Below I have posted part of my script. As you can see the MUI_TEXT_WELCOME_INFO_TEXT string is defined before the MUI_LANGUAGE macro is called. The compiler states that MUI_TEXT_WELCOME_INFO_TEXT is already defined when it compiles the !insertmacro MUI_LANGUAGE line. What do I have to do to make this work? I am using NSIS v2.0rc4.

Thanks in advance,
Michael

<stuff removed here>

; MUI 1.67 compatible ------
!include "MUI.nsh"

; MUI Settings
!define MUI_ABORTWARNING
!define MUI_ICON "${NSISDIR}\Contrib\Graphics\Icons\modern-install.ico"
!define MUI_UNICON "${NSISDIR}\Contrib\Graphics\Icons\modern-uninstall.ico"
!define MUI_HEADERIMAGE
!define MUI_HEADERIMAGE_BITMAP "Header.bmp"
!define MUI_WELCOMEFINISHPAGE_BITMAP "Side.bmp"
!define MUI_UNWELCOMEFINISHPAGE_BITMAP "Side.bmp"
!define MUI_TEXT_WELCOME_INFO_TEXT "This wizard will guide you through the installation of $(^NameDA).\r\n\r\nIt is recommended that you close Microsoft Visual Studio before starting Setup.\r\n\r\n$_CLICK"

; Welcome page
!insertmacro MUI_PAGE_WELCOME
; Directory page
!insertmacro MUI_PAGE_DIRECTORY
; Instfiles page
!insertmacro MUI_PAGE_INSTFILES
; Finish page
!insertmacro MUI_PAGE_FINISH

; Uninstaller pages
!insertmacro MUI_UNPAGE_INSTFILES

; Language files
!insertmacro MUI_LANGUAGE "English"

<more stuff removed here>


Should you not use the '!define MUI_WELCOMEPAGE_TEXT text' as described in the MUI Readme?

However if you really want (this is most likely NOT a good idea) you could '!undef MUI_TEXT_WELCOME_INFO_TEXT' before defining your own version. But use this at your own risk!

Vytautas


Vytautas: Undefining won't change anything.

As said, use MUI_WELCOMEPAGE_TEXT.


I can't believe I cut and pasted the wrong variable name - doh! You are correct. Once I used !define MUI_WELCOMEPAGE_TEX instead everything worked as expected. I had tried undefining the variable but that didn't seem to work. Thanks for the quick response.

Michael