- NSIS Discussion
- Browse Install Location Bug?
Archive: Browse Install Location Bug?
zimsms
23rd February 2004 21:41 UTC
Browse Install Location Bug?
Hello Everyone,
After moving to version 2.0, I noticed in my installers that if I browse for the installation directory the "Welcome to MyInstaller blah blah blah" gets appended to the return value from the browse button. Has this been addressed, or am I experiencing some other problem??
Cheers,
ZIMSMS
Joost Verburg
23rd February 2004 21:55 UTC
Only the product name should be appended. Please attach a script.
zimsms
24th February 2004 14:19 UTC
Hello Joost,
Here is a Multilingual Example Installer with Parameter and Silent Installation Support. Feel free to use it as a contribution. There is also an interesting function in the macros.nsh file to get a parameter value based on a specified parameter from the command line at runtime. (note you would need the modified strstr as well).
To reproduce the behavior with the browse instdir, appending the welcome text, just browse a location, and select a directory for install. It's reproducable every time.
This example was designed to work on 2000, xp, 2003, but will work on 95/98/me/nt if you modify the validos macro.
Cheers,
ZIMSMS
zimsms
24th February 2004 14:24 UTC
Well, considering the example is zipped, and is 2 megs, I guess I can't upload it :cry:
zimsms
24th February 2004 14:27 UTC
I've cut it down to 867 k, by removing the built example...heh, but it's still a tiny bit too big for the upload item....must be the nullsoft header hehehe
Rhonnysparks
24th February 2004 15:56 UTC
upload it externaly then post a link.
Back to the topic, is there any way I can disable this?
zimsms
24th February 2004 16:13 UTC
I gather you could by removing the ability to install to a specified directory by commenting the MUI_PAGE_DIRECTORY insert statement.
zimsms
1st March 2004 15:40 UTC
Hello Joost,
What is the status on this?
CHeers,
ZIMSMS
Joost Verburg
1st March 2004 15:56 UTC
It has already been fixed a few days ago, compile the latest CVS version :)
zimsms
1st March 2004 16:26 UTC
Cool Thsnks! May I ask what caused it, seeing as it didn't affect any of the small scripts I tried?
Joost Verburg
1st March 2004 16:38 UTC
There was something wrong when InstallDir was used in combination with certain folders.
zimsms
1st March 2004 18:52 UTC
I just updated to the latest CVS build, and am still experiencing this issue. It is still reproducable with that example I sent you.
Joost Verburg
1st March 2004 20:14 UTC
As I already said, the binary has not been updated yet so you have to recompile.
However, there still seem to be some problems with the name not being appended at all. That will be checked later.
zimsms
2nd March 2004 13:22 UTC
Ahh, I missed that part. That's cool, better than "welcome to blah blah blah setup wizard" heh. I really appreciate your quick responses.
Cheers!
kichik
5th March 2004 09:55 UTC
The problem is that InstallDir will not look for the backslash in the language string. You should therefore define a language string just for the last part and use:
InstallDir $PROGRAMFILES\$(ProductName)