mattdisaster
31st May 2004 18:04 UTC

Trouble with Nsisdl and ZipDll
  Hey All-
So I started tinkering around with NSISdl and ZipDll this morning, and everything was going smoothly, I was able to set up a remote download of a zip file and everything worked flawlessly. Then (there's always a then) I started working with zipdll and ran into problems. I'm trying to get it to download a zip file and then extract it to a subfolder in my install directory. I know I'm doing osmething wrong, but I cant tell what, when I run the installation it gets to the download portion and gives me an error when it tries to download the zip. I think it has something to do with it not being able to download the file before zipdll tries to open it, heres to coding, any help would be awesome!

Section "Skins" SEC02
NSISdl::download http://members.cox.net/xlobby/jowaldobeta2.zip "$INSTDIR\skins"
Pop $R0 ;Get the return value
StrCmp $R0 "success" +3
MessageBox MB_OK "Download failed: $R0"
Quit
ZipDLL::extractall "$INSTDIR\skins\jowaldobeta2.zip" "$INSTDIR\skins"
SectionEnd

-matt

zimsms
31st May 2004 19:01 UTC

I haven't used ZipDLL before but you should change your StrCmp to:

StrCmp "$R0" "success" +3 

>

It's always best to enclose your values when comparing.

It would also be wise to enclose your URL in the NSISdl call.

Joost Verburg
31st May 2004 19:28 UTC

It's a variable, quotes around it don't make any difference.

The local destination for NSISdl should be a file, not a folder.

mattdisaster
1st June 2004 00:19 UTC

Joost Verburg-
Thanks for the heads up, I'm sorry I'm retarded, I fixed it and everything works awesome now. You guys are the best!

-matt

zimsms
1st June 2004 14:05 UTC

Joost, even if it could contain spaces? Heh, I missed the filename part when I looked at it too....good eye! :D

Joost Verburg
1st June 2004 16:17 UTC

These quotes are only for the compiler to separate parameters. Of course they won't be stored anywhere, so adding quotes here makes no difference.