Archive: Proposal: /NOIEPROXY flag for nsisdl plugin


Proposal: /NOIEPROXY flag for nsisdl plugin
Hi,

I've just made a little modification to nsisdl: I've introduced a new flag called /NOIEPROXY which makes the plugin not to read IE proxy settings, so it tries to download the files directly.
The reason behind this modification is that in certain enviroments, some of the intranet http servers can't be connected via the corporate proxy server and I can't make the users switch to M$IE proxy options just because that single download, it's easier to give them the option to not to use the proxy in that one case.
Use:

The /NOIEPROXY flag should be the first flag for the nsis::download command.
If /NOIEPROXY or /NOIEPROXY=1 is the first flag for this command, then the IE proxy config is not used. Examples:


If this flag is ommitted or for exp. /NOIEPROXY=0 is inserted then IE proxy is used.
Examples:

I think this modification is helpful and does not make the usage or the source code much too complicated. I hope that it might be included in the CVS someday.

Regards,

Memph

Well, I though this topic generates much more interest than that :)
Anyone interested?

Regards,

Memph


Me! <*waves*> :)


Hi Marc,

I forgot to mention, and that might disturb people: If you apply the patch against nsisdl.cpp in the NSISDL source, you'll get the modified source.

The directory where the cpp file to be patched resides is:

C:\Program Files\NSIS\Contrib\NSISdl



The command to apply the patch:
/usr/bin/patch nsisdl.cpp nsisdl.cpp.diff.txt


The patch command requires cygwin to be deployed. If you want, I can upload the modified nsisdl.cpp source here.

Regards,

Memph

confused...
1. do I add the /NOIEPROXY flag to nsisdl.cpp (where?)?
2. what about deleting nsisdl.dll file if my installer has no need to go to any webserver? Is that a working solution?

mdm


Hi mdm,

1: you have to patch your nsisdl.cpp the way I described above. I'll attach to whole source, in case you don't have patch utility. Usage is described in my first post: you have to put this flag right after the 'NSISdl::download' command.
2: Well, I'm not sure if I understand what you mean to say. My patch is to enable an NSIS user to avoid to use MSIE's web proxy settings and go to the web server directly. If your installer does not download data via web, you just simply comment out the 'NSISdl::download' command in your script.

Regards,

Memph


please excuse me for being obtuse here..
my nsisdl.cpp and the one you sent has no line: NSISdl::download.
Is NSISdl::download a command for my nullsoft installation script? I don't have any web downloads within my installation script("If your installer does not download data via web, you just simply comment out the 'NSISdl::download' command in your script").

appreciate your patience,
mdm


Mdm,

'NSISdl::download' is invocation form of "NSISdl" plugin's "download" function, so in this form it should present in an nsi script, so "C:\Program Files\NSIS\Contrib\NSISdl\ReadMe.txt" for details. If you don't want to use web in your NSIS installer you, don't need it and this topic is needles either :)
In the nsisdl.cpp you can find a line starting with "_declspec(dllexport) void download", that's where you can check the C++ source code.

Regards,

Memph


Modified nsisdl.dll
Could you please upload the recompiled nsisdl.dll with the /NOIEPROXY flag?

I would be much obliged


Hi,

Here it goes, along with the source.

Regards,

Memph


Thanks.

Konrad


thanks, added in latest cvs.


Kichik,

Thank you!

Regards,

Memph