moop
17th October 2004 05:34 UTC

What's wrong with my string?
I'm using the ReplaceInFile script from the Archive. It works fine, except when I insert the string I actually want to use... i.e. the tests I run work fine... but as soon as I insert the actual string I want to replace, it dies.

I don't think my syntax is wrong, since I am able, earlier in my installer script, to insert my string (the same one!) into that file.

Here is the text I want inserted:
user_pref("network.protocol-handler.external.deusex", true);
this is what I am entering into my installer:
!insertmacro ReplaceInFile "$PROFILE\Application Data\Mozilla\Firefox\$1\user.js" "$\r$\nuser_pref($\"network.protocol-handler.external.deusex$\", true);" "replacement_text"

(yes that's all one line)
...and this is the error I get when I compile:



!insertmacro: ReplaceInFile
Push: $PROFILE\Application Data\Mozilla\Firefox\$1\user.js
Push expects 1 parameters, got 3.
Usage: Push string
Error in macro ReplaceInFile on macroline 2
Error in script "moop.nsi" on line 300 -- aborting creation process

So... it appears to think that my string is OKAY when I use the same exact string earlier in the file... but somehow now, through this ReplaceInFile script, it gets misinterpreted?

I have re-tested it without using the !insertmacro command, instead inserting the parameters line-by-line using Push and Call (as ReplaceInFile does)... still nothing.

Help?:igor:

Afrow UK
17th October 2004 10:39 UTC

Dump the macro and use:

Push "$PROFILE\Application Data\Mozilla\Firefox\$1\user.js"
Push "$\r$\nuser_pref($\"network.protocol-handler.external.deusex$\", true);"
Push "replacement_text"
 Call RIF

moop
17th October 2004 12:46 UTC

Originally posted by Afrow UK
Dump the macro and use:

Push "$PROFILE\Application Data\Mozilla\Firefox\$1\user.js"
Push "$\r$\nuser_pref($\"network.protocol-handler.external.deusex$\", true);"
Push "replacement_text"
 Call RIF

-Stu

razor_x
17th October 2004 12:53 UTC

I think your macro is failing because you have quotes inside of quotes..this == another string.You can also use strcpy and copy that whole string to a variable,then call that variable in the macro.

strcpy $2 "path"
strcpy $3 "string to search"
strcpy $4 "replacement text"

!insertmacro ReplaceInFile "$2" "$3" "$4"

moop
17th October 2004 13:50 UTC

Originally posted by razor_x
I think your macro is failing because you have quotes inside of quotes..this == another string.You can also use strcpy and copy that whole string to a variable,then call that variable in the macro.

strcpy $2 "path"
strcpy $3 "string to search"
strcpy $4 "replacement text"

!insertmacro ReplaceInFile "$2" "$3" "$4"

Yathosho
17th October 2004 14:13 UTC

!insertmacro ReplaceInFile "$PROFILE\Application Data\Mozilla\Firefox\$1\user.js" '$\r$\nuser_pref($\"network.protocol-handler.external.deusex$\", true);' "replacement_text"

razor_x
17th October 2004 14:21 UTC

The macro is fine.I think your folder may be "Read Only"....

moop
17th October 2004 15:06 UTC

Yathosho:
I get
!insertmacro: ReplaceInFile
Push: $PROFILE\Application Data\Mozilla\Firefox\$1\user.js
Push expects 1 parameters, got 3.
Usage: Push string
Error in macro ReplaceInFile on macroline 2
Error in script "moop.nsi" on line 300 -- aborting creation process during compilation.

razor_x:
I had SetFileAttributes on user.js to NORMAL - and as I mentioned in the top post, I am able to add that text to the file if the text doesn't exist... but I can't subtract/replace it. I am using the exact same string, too... cut & paste, looked it over, read the documents on quotes and symbols... this all seems very odd to me. Odd enough that I might consider it a bug if I didn't first think it was my inexperience.

:(

pengyou
17th October 2004 15:12 UTC

The macro is the problem - it uses "" and the search string includes "".

One way to solve this is to use

Push "$PROFILE\Application Data\Mozilla\Firefox\$1\user.js"
Push '$\r$\nuser_pref("network.protocol-handler.external.deusex", true);'
Push "fwargh"
Call RIF

razor_x
17th October 2004 15:27 UTC

I solved it like this...my example

strcpy $0 "D:\Documents and Settings\mysettings\Application Data\Mozilla\Firefox\Profiles\default.cvn\prefs.js"
strcpy $1 '"network.protocol-handler.external.deusex"' ;we add the string inside a string to a variable(note the extra single quotes)
strcpy $2 "user_pref($1, true);" ;add that variable to the string to search
strcpy $3 "" ;delete the string

!insertmacro ReplaceInFile "$0" "$2" "$3"

macro works fine...guess yours would look something like this..with the correct variable for the path of course

moop
17th October 2004 16:24 UTC

Originally posted by pengyou
The macro is the problem - it uses "" and the search string includes "".

One way to solve this is to use

Push "$PROFILE\Application Data\Mozilla\Firefox\$1\user.js"
Push '$\r$\nuser_pref("network.protocol-handler.external.deusex", true);'
Push "fwargh"
Call RIF

razor_x
17th October 2004 16:47 UTC

Edit2: Oh just noticed - do NOT edit your prefs.js file, razor_x... bad things. The user.js file will be read into Firefox just like prefs.js, but without messing up your whole Firefox setup (I eventually backed up my bookmarks, history, and extensions, and un/re-installed Firefox... man what a pain, until I found out editing user.js works just the same without the chaos).