Archive: Proofread Installer Script


Proofread Installer Script
First, I'd like to thank the users in this forum for answering my questions. Not only did I recieve prompt and concise replies, but in addition searching through the forums answered a plethora of additional questions.

I now have a fairly robust install script for a largish open source program World Wind. This installer will undoubtedly be used in future versions. In addition we are using the NSIS installer for enhancement packs.

There is a minor problem with the installer, it isn't getting added to ADD / REMOVE programs even though the registry is set.

If any forum members have time could they proofread my script and offer any suggestions?

The script may be found at http://www.worldwindcentral.com/dev/wwdelta.nsi

Thank you,
Llynix


Try this:

WriteRegStr HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\NASA - World Wind v1.2" "DisplayName" "Worldwind v1.2d"
WriteRegStr HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\NASA - World Wind v1.2" "UninstallString" '"$INSTDIR\uninstall.exe"'
WriteRegDWORD HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\NASA - World Wind v1.2" "NoModify" 1
WriteRegDWORD HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\NASA - World Wind v1.2" "NoRepair" 1
I don't think you can have "World Wind v1.2" as a subkey of "NASA".

I don't know... maybe this line:


WriteRegStr HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\NASA\World Wind v1.2" "UninstallString" '"$INSTDIR\uninstall.exe"'

to this one:

WriteRegStr HKLM "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\NASA\World Wind v1.2" "UninstallString" "$INSTDIR\uninstall.exe"

I will try that when I get home.. I had a sneaking suspicion that was the problem to begin with.

In addition I already found one error :) My windows compatibility hack was supposed to copy over a few exsisting DLL's to replace them with the win 95/98/ME versions..

Unfortuantly.. I write them first.. and then copy over the 2000/xp dll's.. stupid me.

The .nsi script has been fixed.. and with any luck by tomorrow we shall have a nice installer that actually works for win 95/98/ME (crosses fingers)


The script may now be found at http://www.worldwindcentral.com/dev/wwepsilon.nsi


Just a quick reply. (noticed a couple of 404's for these files on my site, so I thought I'd followup.) The latest versions of our installer can be found via CVS @ sourceforge: http://sourceforge.net/projects/nasa-exp/

Check the directory called "wwinstall"

It's browsable via the web so anyone can see, we are quite open to suggestions / contributers and it also may be helpful for newbies to follow and see a full-install / patch-install in progress.

Happy Hacking.