kichik
4th February 2005 21:22 UTC

2.05 released
2.05 was released a couple of hours ago. Changelog and release notes can be found at:

http://sourceforge.net/project/shown...ease_id=302407

Downloads can be found at:

http://sourceforge.net/project/showf...ease_id=302407

Known problems:

• The version of Russian.nsh which is supplied with 2.05 doesn't compile. Use the attached version instead.
• If a section group is the first section, other section groups will not behave properly. Add an empty hidden section at the very top of the script to work around this problem.

Koen van de Sande
5th February 2005 23:20 UTC

Will 2.06 be bugfix-only or will there be room for something like an updated VPatch plug-in? This depends of course on the time schedule because VPatch should be tested properly before it is put into a stable NSIS.

Koen van de Sande
6th February 2005 20:29 UTC

VPatch 3 RC3 is feature-ready (NSIS-wise): VPatch 3 RC topic

Only the GUI needs some work and the documentation (the NSIS one is up to date though, just not the stand-alone one).

kichik
10th February 2005 19:32 UTC

Bug fix only.

ImmortAlex
15th February 2005 04:09 UTC

I think adding hidden Section still doesn't fix all problems with groups. In my script in some cases I need to hide and deselect some other sections inside groups, so in components page pre-function I use

SetSectionFlags ${sec} 0
SetSectionText ${sec} ""

And I don't see this section in components page. But when I leave this page, selection bit in section flags is set (and I can see it in page leave-function), so my Section installs.

All works fine in 2.04.

I'm trying to isolate this bug, writting some simple script, but can't reproduce it, and it's very strange...

kichik
15th February 2005 18:22 UTC

It's not a bug, it's a fixed bug.

Invisible sections weren't always affected by a change of the installation type (bug #1045722)

ImmortAlex
16th February 2005 05:00 UTC

OK, waiting for 2.06

Takhir
17th February 2005 08:17 UTC

AdvSplash and LangDLL plug-ins problem in the NSIS 2.05 - installer goes to background after splash/lang window disappears. AdvSplash worked fine in 2.03 (and probably in 2.04, but I am not sure). LangDLL had the same problems in 2.04 (and may be earlier).
This happens on the one of my comps only - Win2K Server Rus SP2, PII-350 256 MB (and bad video card). On the other comp with Win2K Pro Eng SP4, PIII-533 128 MB plug-ins work fine. The same with MSI Banner plug-in. My NewAdvSplash still works correct on both comps. May be first comp works too slowly? But why AdvSplash plug-in worked correct on the same comp in 2.03 version? Any "fixed bugs"? ;)

Takhir
17th February 2005 08:26 UTC

Forgot to attach test script - reproduces situation with AdvSplash.

kichik
17th February 2005 18:28 UTC

It works fine for me on both slow and fast computers. Since it only happens on one of your computers, maybe it's a problem with it? Have you tried running it in safe mode where some programs will not interfere? Have you tried finding the differences between "your NewAdvSplash" and the other plug-ins?

Takhir
17th February 2005 18:50 UTC

I only wanted to help with 2.05. First versions of my plug-in had this problem, but I did few iterations and made it working like AdvSplash in previous NSIS releases (i.e. correct). I don't want my post looks like advertisement (and this is why I not gave any links :) ), may be this is my problem only, I know how to solve it for me and it's OK ;)

kichik
17th February 2005 19:23 UTC

I was not suggesting you're trying to advertise anything. I was simply putting up suggestion to solve this problem of yours. But now you tell me you already have the solution. So why not just submit a patch instead of just reporting the problem?

kichik
17th February 2005 21:29 UTC

As you all have probably noticed already, I didn't release 2.06 last weekend. I didn't have too much time last weekend, and I won't have this time too. Other than the Russian language file bug, there aren't any major problems with 2.05 that affect everyone, so it's not that bad anyway. 2.06 should be released in two or three weeks, on schedule. Hopefully, it will include some more automated testing to prevent problems, such as the language file problem, in the future.

Takhir
18th February 2005 08:05 UTC

KichiK, I have not clear understanding of "background" problem in AdvSplash. This is why while adding my little changes to base version (C-file header includes change history from Justin to my add-ons) I had to repeat changes step-by-step moving from old to new version and finally it began and continue working (and this is my solution ;) ). AdvSplash.c 2.03 and 2.05 "diff -B --ignore-all-space" 7 kB shows that someone worked hard with file formatting (and made little changes in "state" var). But finally I do not see any reasons for AdvSplash to change behavior, something weird again..

kichik
18th February 2005 09:05 UTC

CVS provides a log:

http://cvs.sourceforge.net/viewcvs.p...sh/advsplash.c

Nothing was changed in AdvSplash. The only thing that was changed in 2.03 is in Ui.c:

http://cvs.sourceforge.net/viewcvs.p...1.215&r2=1.216

PerditionC
27th February 2005 20:41 UTC

(I'm using latest NSIS available via the menu->Update latest
development and this is the AbiWord installer.)
I'm not sure if this is a bug (either in NSIS or my script) or a change somewhere between 2.02 and 2.05, but my installer script builds fine but there are two major differences:
- the default install type is now custom instead of typical
Is there a new command that must be used (or maybe one I
should have been using) to indicate the default one?
- subsections don't work like they used to, in particular,
when only partial subitems are selected the check box in
the parent remains clear or selected (whichever it was)
instead of the former grey+check, even unselecting all
items does not clear the parent (group) checkbox (only
directly clicking on it). Is this the expected bevahiour,
part of the bugs you are talking about above, or something
that requires a change in my installer [if so I would
appreciate directions as what to look into]?

Thanks for helping me determine where the problem is.

kichik
1st March 2005 17:56 UTC

According to the latest abi/src/pkg/win/setup/NSISv2/AbiWord.nsi, you have a section group (subsection) as the very first section. This is the trigger for the second known problem described in the first post. Your description also matches the bug symptoms. Simply add an invisible section before the first section group to avoid this bug.

Using the latest from CVS didn't help because you probably didn't recompile makensis.exe. I no longer upload a new version of makensis.exe to CVS for every change. I only upload a new version when I release a new version of NSIS. I intend to remove all executables from CVS once I finish a build system I'm currently working on. The new build system will build the entire NSIS package so it'll be easy to make a complete nightly package.

PerditionC
4th March 2005 19:56 UTC

Thanks, I recompiled latest cvs version and using it the
selection of sections within groups now appears to be fine,
however, the default install type is still always Custom.
I added an initial hidden empty section and it made no
difference regarding the install type, I even added explicit
calls to SetCurInstType (1st tried in .onit function, and
then even tried in my 1st section). Should I file a bug for
this or do you have any ideas/suggestions I should try first? Thank you.

kichik
4th March 2005 21:33 UTC

I have tried to reproduce this with the latest CVS version, but couldn't get it to start with the custom install type selected. It always starts with typical. It might be because of the many changes I've made to the script.

I couldn't find anything in the script that would make SetCurInstType in .onInit, placed after !insertmacro SectionList "InitSection", not work. Any chance you can get a smaller script reproducing this problem?

PerditionC
4th March 2005 22:12 UTC

I narrowed down my problem to the add/remove aspect of
my installer. When a previous install exists (ie it finds
the list of installed components) it should set the
corresponding sections to match, but apparently is failing
somewhere and pretty much just deselects everything;
but when I remove the entries so as to mimic a fresh
install it does correctly start with typical.
I will do some more testing and see if I can track down
what is causing the difference.

kichik
4th March 2005 22:17 UTC

There was another change in 2.05 that might have caused this. Selecting a section group with SetSectionFlags now affects its children too, just like when the user clicks a section group. However, I didn't notice any section groups on the list in SectionList. Is there another place in the script that might set flags for section groups?

PerditionC
4th March 2005 22:43 UTC

That is it then, as groups are also set/unset.
Thanks for the help, I will change the installer
to check and skip [un]selection for groups.

Takhir
11th March 2005 10:56 UTC

AdvSplash - GlobalFree(bad pointer) bug I guess. Updated code of my plug-in is here http://forums.winamp.com/showthread....19#post1612419

kichik
11th March 2005 11:28 UTC

Thanks, fixed.