Banner with CANCEL button

Instructor
31st March 2005 07:20 UTC

Banner with CANCEL button
There is have one http://nsis.sourceforge.net/archive/...instances=0,32

But this "NxS MSI LoaderDlg" plugin are crashes then it called from Custom Page "Function LeaveCustom" (and MSI Banner too).

I trying contact with saivert (author) with no luck.

Can anybody fix this problem (i'm have poor knowledge of C++)?

Takhir
31st March 2005 09:06 UTC

May be attached version.. I had not script to test cross-dialog situation.

Joel
31st March 2005 14:03 UTC

Those "crashes" are because you need to handle the banners after the page is gone... we can't do everything for you :)

Instructor
31st March 2005 14:43 UTC

Thanks, Takhir

Those "crashes" are because you need to handle the banners after the page is gone... we can't do everything for you

Before Takhir change the code setup crashes immediately after "NxSMSILoaderDlg::Show /NOUNLOAD ..."

Another problem:
"NxSMSILoaderDlg::update /NOUNLOAD ..." is clear the stack :( I use it in the callback function (of course setup quit from function after it)

Takhir
31st March 2005 15:32 UTC

New /end parameter - see attached script.
I also increased height of the static control displaying cuurent path (3 lines max now).

Instructor
31st March 2005 16:58 UTC

WOW, Takhir one more thing. CANCEL button is allways disabled (trying: /can 0 and /can 1).

EDIT:
And /top parameter also use default value

Takhir
31st March 2005 19:58 UTC

90% of new code :)

Instructor
31st March 2005 21:43 UTC

Takhir, my russian amazing friend, thank you.

P.S.
Necessarily publish it (you fix all problems and reduced the size of packed plugin by 85 %)

Takhir
1st April 2005 09:23 UTC

Sources and binaries. Banner path text flicking and foreground window position improved, Task bar button issue fixed, dll and entry points renamed (NxSMSILoaderDlg.dll->nxs.dll, show->Show... - see Readme), file size 5.5 kB now (2.3 kB in zip), 2 samples included - original saivert' and sent by Instructor. "Change history" header added to C file.

Saivert, please don't kill me :)

DrO
1st April 2005 12:02 UTC

Originally posted by Takhir
Saivert, please don't kill me :)

that'd be an interesting fight to watch :)

-daz

Instructor
1st April 2005 13:13 UTC

Then I run example.nsi in WinMe (in WinXP all fine) it shows:

Takhir
1st April 2005 15:51 UTC

I see, 98/Me not updates frame size on window style changes (related to hidden or visible Task bar button /h option), so banner will have on 98/Me toolwindow style - decreased caption height, regular font in the /h 1 mode (no task bar button), bold otherwise (system defines this). I know about hidden parent window and appwindow style tricks, but I don't like this way. New version attached.

Instructor
1st April 2005 18:52 UTC

I made some changes in readme and examples. If something will seem to you interesting.

Takhir
2nd April 2005 14:58 UTC

Thanks, Instructor!
I added your files to package, but I had to do some changes in example.nsi - like saivert wrote, first installer's page stays minimized without explicit ShowWindow in the .onGuiInit if banner was shown in .onInit function. The same happened on my XP with "100% done" message box after banner destroyed in .onInit, so I commented this line in your script.

Instructor
2nd April 2005 16:37 UTC

I'm grateful to you (and to saivert :) too).

saivert
3rd May 2005 07:06 UTC

Hi! This is great work. Takhir and Instructor, thanks for fixing my code (that's why I included the source code). I tried to fix MSIBanner's code, but since I based my code on the MSIBanner project think a lot of the bugs from MSIBanner replicated in my plug-in. I should have started from scratch. But I guess you (Takhir) have reworked the code now, so now most of it is new code (hopefully).

But my idea with a Cancel button was great, right?
And why did you rename the plug-in to nxs.dll. NxS is just my prefix. My real name is Nicolai Syvertsen, so I just made that into NxS (putting in an x just cos' it's cool).
I don't think you make the installer that much smaller by keeping filename sizes short. Isn't the datablock compressed anyway??

But again (sorry for caps lock): GREAT WORK!

SJSJ
31st May 2011 12:03 UTC

Unicode version?
Hi,

The Nxs banner plugin was exactly what I was looking for. It works great.
Do you have a Unicode version, Takhir?

I tried changing the code by following instructions from http://forums.winamp.com/showpost.ph...95&postcount=6 but did not succeed.
The pop up comes but the marquee does not.

Please let me know if somebody has tried the Unicode version.

Thanks!!

MSG
31st May 2011 15:27 UTC

Have you tried using it with the CallAnsiPlugin plugin?

SJSJ
1st June 2011 04:38 UTC

Not yet!
Thanks, MSG, for the suggestion.
Looks promising.
I shall try and post the results!

SJSJ
1st June 2011 05:36 UTC

MSG, it worked :-D
That is a great plugin.
Thank you!

Takhir
4th June 2011 10:02 UTC

Excuse for a time delay, Unicode version uploaded http://nsis.sourceforge.net/File:Nxs.zip

SJSJ
6th June 2011 07:26 UTC

That is great!
I shall check that too.
Thanks, Takhir.

Yathosho
6th July 2011 11:30 UTC

i don't care, but for the record: the marquee banner does not work on windows 98 :)