Comperio
13th July 2005 14:08 UTC

define function on-demand?
I'm just trying to clean up my code a bit. I like to wrap my own functions in an NSH file that I can !include when I need them using macros and return varaibles. (I find this much more convenient than using stack commands within a section or function.)

My list of functions (and NSH files) keeps growing. I'd like to take the ones I use most often and put then into a single NSH file. However, I might not use every single function declared in an NSH file.

I'd like to know if anyone has any tricks of defining a function "on demand". In other words, I want to automatically create a function only when needed. I thought perhaps I could encapsulate the function within "!ifdef" statements, but I'm not sure if that's the right way to go.

Here's an example of a basic NSH file layout that I currently use. Any advice would be appreciated. Thanks!
______________________________________________________
!macro MyFunc Return_var Input_var
push ${Input_var}
Call MyFunc
Pop ${Return_var}
!macroend

!define CoolFunction "!insertmacro MyFunc"

Function MyFunc
Exch $0
push $1
; do stuff with $0
; store result in $1
exch $1
exch
pop $0
FunctionEnd

Yathosho
13th July 2005 14:32 UTC

it would definitely be nicer if one could push instructions to a function in a php-like way.

Call MyFunc ${1} ${2} ${3}

deguix
13th July 2005 16:12 UTC

That's what StrFunc/UseFunc, and Instructor's header files do. The best of them would be UseFunc, because function calls and the functions themselves have less instructions than the others.

Just look at the call to StrCase now:

  !macro ${_FuncCall} ResultVar String Type
  ${_UseFunc_FuncCall_Start}
    ${UseFunc_Echo} `$ {${_Un}${_Name}} "${ResultVar}" "${String}" "${Type}"`
    Push `${String}`
    Push `${Type}`
    Call `${_Un2}${_Name}`
    Pop `${ResultVar}`
  ${_UseFunc_FuncCall_End}
  !macroend

${_UseFunc_DefHeader} `Cool` `NSIS Cool Functions Header File` `1` `0` `` `` `2005 Comperio`

${_UseFunc_DefFunc} `Function` `CoolFunction Function` `1` `0` `` `` `2005 Comperio`

  !macro ${_FuncCall} Return_var Input_var
  ${_UseFunc_FuncCall_Start}
    ${UseFunc_Echo} `$ {${_Un}${_Name}} "${Return_var}" "${Input_var}"`
    Push `${Input_var}`
    Call `${_Un2}${_Name}`
    Pop `${Return_var}`
  ${_UseFunc_FuncCall_End}
  !macroend

  !macro ${_Func}
  ${_UseFunc_Func_Start}
    Exch $0
    push $1
    ; do stuff with $0
    ; store result in $1
    exch $1
    exch
    pop $0
  ${_UseFunc_Func_End}
  !macroend