Chilli24
6th August 2005 13:07 UTC

show Readme on uninstaller's finish page
Hi. I looked over the docs but I don't seem to understand how I can show a readme file on the finish page of the uninstaller. I want something like this (for installer):

!define MUI_FINISHPAGE_SHOWREADME "$INSTDIR\readme.txt"

or

!define MUI_FINISHPAGE_SHOWREADME_FUNCTION ShowReadme

Is anybody nice enough to help me. I'm sure there is a very easy way to do this, but I don't seem to find it.

Thanks in advance.

kichik
6th August 2005 13:12 UTC

MUI_FINISHPAGE_SHOWREADME is explained in the Page Settings section of the MUI readme. On the very top of this section, you'll find:

Note: There is no difference between installer and uninstaller page settings.

deguix
6th August 2005 13:14 UTC

Just put the defines right before you insert the finish page macro.

EDIT: Incredible that kichik and my comments add to each other nicely, even with 2 minutes of difference between the posts.

Chilli24
6th August 2005 13:20 UTC

I tried this:

!define MUI_FINISHPAGE_SHOWREADME
!define MUI_FINISHPAGE_SHOWREADME_FUNCTION un.ShowLogs
!define MUI_FINISHPAGE_SHOWREADME_TEXT "View installation history"
!define MUI_FINISHPAGE_SHOWREADME_NOTCHECKED
!insertmacro MUI_UNPAGE_FINISH

but when compiling it gives me these errors:

Error: variable "MUI_NOABORTWARNING" already declared
Error in macro MUI_PAGE_FINISH on macroline 33
Error in macro MUI_UNPAGE_FINISH on macroline 7

Indeed I have already defined MUI_ABORTWARNING and MUI_UNABORTWARNING, but it's got to do with a readme in the finish page?

Chilli24
6th August 2005 13:40 UTC

Turns out it has nothing to do with MUI_ABORTWARNING and MUI_UNABORTWARNING. What is MUI_NOABORTWARNING? i cannot find in the MUI readme. And what's it got to do with the readme?

kichik
6th August 2005 13:44 UTC

It's an internal variable of the MUI. I've asked Joost to take a look.

Chilli24
6th August 2005 14:51 UTC

Thanks. In that case I will wait for Joost's response.

Joost Verburg
6th August 2005 17:51 UTC

This issue has been fixed in Modern UI 1.73 which is now available on the CVS server.

Chilli24
6th August 2005 20:16 UTC

Maybe I'm too tired or just blind but just by browsing the CVS (don't have a CVS client, no need), I don't seem to find Modern UI 1.73.
Can anyone help ? Thanks

Chilli24
6th August 2005 21:24 UTC

Problem solved. I just found out about nightly builds. :)

Chilli24
31st August 2005 09:58 UTC

Hello again.
I downloaded the 2.09 (with advanced logging enabled) hoping that finally this issue is fixed. But it appears that it's not.
I have this:

!define MUI_FINISHPAGE_SHOWREADME
!define MUI_FINISHPAGE_SHOWREADME_FUNCTION un.ShowLogs
!define MUI_FINISHPAGE_SHOWREADME_TEXT "View installation history"
!define MUI_FINISHPAGE_SHOWREADME_NOTCHECKED
!insertmacro MUI_UNPAGE_FINISH

When I compile it this is what I get:
!insertmacro: MUI_UNPAGE_FINISH
!define: "MUI_FINISHPAGE_CURFIELD_TOP" already defined!
Error in macro MUI_FUNCTION_FINISHPAGE on macroline 147
Error in macro MUI_PAGE_FINISH on macroline 46
Error in macro MUI_UNPAGE_FINISH on macroline 7

Any ideas?

Chilli24
1st September 2005 16:57 UTC

Anybody any ideas ?

Chilli24
3rd September 2005 11:50 UTC

I guess this is still a bug.

kichik
3rd September 2005 11:58 UTC

It's an internal define of the MUI. I've asked Joost to take a look.

Joost Verburg
4th September 2005 22:11 UTC

There is a bug that causes this compile error when 'Show Readme' or other checkboxes are used on multiple pages. It has been fixed in the lastest MUI version (uploaded to CVS).

Chilli24
5th September 2005 08:42 UTC

OK...It works with the normal makensis.exe. With the one that has logging enabled it doesn't work.

Joost Verburg
5th September 2005 15:44 UTC

It is not related to the makensis compiler. You should download the latest development version to get it to work.