pabs
16th September 2005 04:04 UTC

debian scons build failure win cvs
scons .91 was uploaded to debian, so I can try to build nsis cvs again. I got this error when I tried today's CVS:

pabs@chianamo:~/devel/debian/misc/nsis/NSIS$ scons SKIPPLUGINS=System
scons: Reading SConscript files ...
Delete("nsis-16-Sep-2005.cvs")
Delete(".instdist")
Delete(".test")
Using GNU tools configuration
AttributeError: 'module' object has no attribute 'CommandGenerator':
File "SConstruct", line 179:
envs = SConscript('SCons/Config/gnu')
File "/usr/lib/scons-0.96.91/SCons/Script/SConscript.py", line 557:
return apply(method, args, kw)
File "/usr/lib/scons-0.96.91/SCons/Script/SConscript.py", line 494:
return apply(_SConscript, [self.fs,] + files, {'exports' : exports})
File "/usr/lib/scons-0.96.91/SCons/Script/SConscript.py", line 226:
exec _file_ in call_stack[-1].globals
File "SCons/Config/gnu", line 37:
cross_env(stub_env)
File "SCons/Config/gnu", line 9:
env.Tool('crossmingw', toolpath = ['../Tools'])
File "/usr/lib/scons-0.96.91/SCons/Environment.py", line 1090:
tool = apply(SCons.Tool.Tool, (tool, toolpath), kw)
File "/usr/lib/scons-0.96.91/SCons/Tool/__init__.py", line 78:
module = self._tool_module()
File "/usr/lib/scons-0.96.91/SCons/Tool/__init__.py", line 90:
return imp.load_module(self.name, file, path, desc)
File "../Tools/crossmingw.py", line 107:
None

kichik
16th September 2005 11:36 UTC

The attached patch solves it for me. Let me know if it works for you as well.

pabs
16th September 2005 16:57 UTC

It worked for me too. However, now I get the following build errors when building each of the stubs (everything else builds fine) .

<snip>
Source/exehead/Ui.c:1496: warning: implicit declaration of function `ListView_SetExtendedListViewStyleEx'
<snip>
i586-mingw32msvc-g++ -o build/release/stub_bzip2/stub_bzip2.exe -s -mwindows -nostdlib -Wl,--exclude-libs,msvcrt.a -Wl,--file-alignment,512 -Wl,-e,_WinMain@16 -Wl,-Map,build/release/stub_bzip2/stub_bzip2.map -T /home/pabs/devel/debian/misc/nsis/NSIS/SCons/Config/linker_script build/release/stub_bzip2/bgbg.o build/release/stub_bzip2/components.o build/release/stub_bzip2/exec.o build/release/stub_bzip2/fileform.o build/release/stub_bzip2/Main.o build/release/stub_bzip2/Ui.o build/release/stub_bzip2/util.o build/release/stub_bzip2/crc32.o build/release/stub_bzip2/bzlib.o build/release/stub_bzip2/decompress.o build/release/stub_bzip2/huffman.o build/release/stub_bzip2/resource.o SCons/Config/memcpy.c SCons/Config/memset.c -lkernel32 -luser32 -lgdi32 -lshell32 -ladvapi32 -lcomdlg32 -lcomctl32 -lole32 -lversion -luuid
build/release/stub_bzip2/Ui.o:Ui.c:(.text+0x1be7): undefined reference to `_ListView_SetExtendedListViewStyleEx'
collect2: ld returned 1 exit status
scons: *** [build/release/stub_bzip2/stub_bzip2.exe] Error 1
scons: building terminated because of errors.

kichik
16th September 2005 16:59 UTC

Is ListView_SetExtendedListViewStyleEx not defined in CommCtrl.h?

DrO
16th September 2005 17:25 UTC

it should be unless someone is using an old/incomplete version of that header

-daz

pabs
17th September 2005 02:15 UTC

It is, but it is only defined if _WIN32_IE is greater than 0x0400. I think it is best to define this as 0x0500 or greater in the NSIS source to enable as many features as possible.

kichik
17th September 2005 09:34 UTC

It's actually already 0x0500. The problem was that it was defined in Platform.h which was included after CommCtrl.h in Ui.c. I've moved it to the SConscript and it works now with my MinGW.