bg123
6th October 2005 23:37 UTC

NSIS.Library.RegTool.v2.exe is queued for delete by previous setup reboot
I run my setup and it says reboot is required. In registry there is a RunOnce entry to execute "c:\WINDOWS\System32\NSIS.Library.RegTool.v2.exe /S".
There is also a registry entry HKLM\SOFTWARE\NSIS.Library.RegTool.V2\ with entries of dlls to register on boot

After reboot, the RunOnce and associated SOFTWARE\NSIS.Library registry entries go away, and my app is installed and ready to go.

There now is an entry in "HKLM\SYSTEM\CurrentControlSet\Control\Session Manager" called "PendingFileRenameOperations" with value data
saying to delete C:\WINDOWS\System32\NSIS.Library.RegTool.v2.exe

If I run setup again, the RunOnce entry is added but the PendingFileRenameOperations is still there.

On reboot, windows puts up a message box saying it cannot find C:\WINDOWS\System32\NSNS.Library.RegTool.v2.exe so
the second install does not complete.

Help!

bg123
7th October 2005 16:29 UTC

Is rebooting twice not considered a problem?
Run installer, which requires reboot, then after reboot install something else which requires reboot, then during that reboot windows cannot find NSIS.Library.RegTool.v2.exe, because previous reboot put NSIS.Library.RegTool.v2.exe in the PendingFoleRenameOperations list so it was deleted before the RunOnce tried to complete the second setup.

Am I doing something wrong? Using NSIS 2.10

kichik
7th October 2005 16:32 UTC

You're not doing anything wrong. There's a problem with files that are queued for deletion and then used again.

I'm tempted to put RegTool in the temporary directory and just leave it there. It's very small, and will be even smaller without the deletion on reboot queueing code. Any comments?

bg123
7th October 2005 16:51 UTC

I have no problem with leaving the file around at all. Is there a script file i can edit to make this happen?

Or, it could be arranged that any time the regtool is added to RunOnce, any PendingFileRenameOperations entry for it could be removed so the RunOnce will get to run. Then you still have the delayed cleanup of regtool on the next boot (unless someone runs another nsis based install)

kichik
7th October 2005 17:12 UTC

The PendingFileRenameOperations entry is not documented properly anywhere at MSDN. I don't think it'd be a good idea to mess with it.

To get RegTool to not delete itself and write to the temporary directory a few source changes needs to be made. In attach ZIP, you'll find a patch for the source code, the complete Library.nsh with the change and a compiled version of RegTool. Please test it and let me know how it goes.

If it does work, we need to consider what to do with older versions. The easiest solution would probably be bumping the version. This way, nothing bad will happen in the rare-chance that some DLL is installed to the temporary directory, which will cause the RegTool to be deployed there.

bg123
7th October 2005 19:23 UTC

The Regtool.bin worked correctly. When I was putting the changes into my nsis installation, I did my usual diff of the changed files. Library.nsh changed the file location of regtool to $TEMP, but did not change the RunOnce entry, it still used $R2. I tried it as is anyway, and of course it could not find regtool on second setup reboot. The $TEMP is in my user directory localsettings. Instead of changing the RunOnce entry in the changed Library.nsh, I reverted to the old 2.10 one. I have no problem with the exe being left in winsys. My own uninstalls do not remove my common dlls from there either. Not an issue for me, though I will follow however you decide (presumably in 2.11)

Everything works fine! Thanks very very much!

kichik
7th October 2005 20:25 UTC

Keeping it in $SYSDIR would be a problem, because the path it's kept in is not always $SYSDIR. It's actually the path of the first installed DLL. This could leave over a lot of copies of the tool.

bg123
7th October 2005 22:36 UTC

Could the Library.nsh use a "random" (GUID) file name, like it does for the entries under the HKLM\Software\NSIS.Library.RegTool.v2, for the name of the exe it deposits in $R2 or $TEMP, and adds to RunOnce ?

If the regtool can figure out its exe file name and do the MoveFileEX to delete on next boot, it can be safely deleted, since another run of setup would extract it with a different filename for RunOnce to find.

Anders
8th October 2005 01:19 UTC

Originally posted by kichik
I'm tempted to put RegTool in the temporary directory and just leave it there. It's very small, and will be even smaller without the deletion on reboot queueing code. Any comments?

bg123
8th October 2005 04:19 UTC

Originally posted by Anders
why cant RegTool just delete itself when its done?

---

bg123
8th October 2005 04:28 UTC

This works:

1. Use the original Program Files\NSIS\bin\RegTool.bin, it figures out its filename and tells windows to delete it on next reboot.

2. Change Program Files\NSIS\Include\Library.nsh :
Change lines

File /oname=$R2\NSIS.Library.RegTool.v2.exe "${NSISDIR}\Bin\RegTool.bin"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\RunOnce" \
"NSIS.Library.RegTool.v2" '"$R2\NSIS.Library.RegTool.v2.exe" /S'

to
File /oname=$R2\NSIS.Library.RegTool.v2.$__INSTALLLLIB_SESSIONGUID.exe "${NSISDIR}\Bin\RegTool.bin"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\RunOnce" \
"NSIS.Library.RegTool.v2" '"$R2\NSIS.Library.RegTool.v2.$__INSTALLLLIB_SESSIONGUID.exe" /S'

Changed version attached.

The RegTool program gets a unique name, and RunOnce key knows to run it. After reboot regtool has run and there will be a pending delete of that file for the next boot. Another setup run before next boot will set up RegTool with a different .exe name and RunOnce entry, and on boot the old RegTool is deleted but the new one is still there and it runs (queuing itself for delete on next boot). I think any number of setups could be run with reboots between or not.

Anders
8th October 2005 05:31 UTC

Quote:

StrCpy $R3 $R3 -4 1