Archive: Lots of InetC crashes in NSISdl mode
Lots of InetC crashes in NSISdl mode
Hi all,
I'm using InetC to download a file in the install page, but it crashes during the download 25% of the time.
The crash is always during the download, most at the beginning or the end.
I noticed there is no crash in POPUP or BANNER mode, but having the download progress within the main NSIS window is much better than a new popup window.
Any help you be appreciated,
Thanks! :D
The problem is that this never happened on my comp. Can you test InetLoad in the same mode? Or may be you can even run Inetc under VS debugger? Something like this
- open inetc project in VS;
- build dll with "Debug" info (combo on the tool bar)
- compile nsi file (build installer) - new dll must be in NSIS/plugins folder, I am not sure this path is set for debug build;
- in VS set installer file as executable for debug;
- run it all from VS
(not sure this works :) )
We (I and Backland) finally fixed NSISdl mode crashes. Or we think we did it :) Backland idea was simple: remove and forget all NSISdl code and write new one in the same manner as /popup and /banner were done. When writing this feature I added some other minor improvements, so test required.
If anybody want to test plug-in - it is here http://nsis.sourceforge.net/Inetc_plug-in
Also thanks Backland for the 'center parent' function and a lot of time spent for testing :)
And please note that 'post' is now inetc.dll entry point (not option in the 'get' call).
Thanks for posting this update Takhir.
I have tested this and it works great so far, but all my tests have been on computers with XP SP2.
If anybody else could test this with other versions of Windows, it would be great.
I hope that this plugin is finally stable in all modes, as this is the most feature packed internet plugin available for NSIS.
Cheers :)
When I tried the new Inetc plugin (in NSISdl mode) on my Win98SE system I found that the download Cancel button and download progress bar disappeared if another window was moved on top of the installer and then moved away.
Part of the progress bar re-appeared when the data for the bar changed but the Cancel button never re-appeared.
Thanks pengyou,
Looks like some of the repainting code need to be adjusted!
I also found re-paint problem on 2003 server, but after small changes it looks correct, new build uploaded. And Readme now reflects curent WIKI page :)
The NSISdl plugin hides the "Show details" button.
When the Inetc plugin is used to replace the NSISdl plugin I think it should also hide that button.
Here are some screenshots showing what happens when I click the "Show details" button while Inetc is downloading a file on my Win98SE system.
I think a good option would be hide the button and the detail list within the NSIS script using the Getdlgtem and Showwindow functions
I guess an extra parameter could be added to do this from within the plugin, but you have more control over this behaviour from within your own script
I think in the next verion the progressbar will be laid out much neater and look the same as the real NSIS one, because it looks a bit weird in those screenshots
Cheers :)
I am leaving to vacations, will be back Sep 20.
2 Backland - can you offer a formula for plug-in' top? This should work both in basic and modern UI ;)
I'll check it out ;)
New version uploaded. It was 100% stable during tests.
New features: plug-in uses parent dialog font (NSISdl mode) and progress bar style.
2 new options: cancel_button_text for NSISdl mode and UserAgent http header value.
Again many thanks to Backland who offered new features/options and spent a lot of time testing the plug-in.
Everything works really great, but here is what I've noticed:
if you run the plugin a second time in NSISdl mode in the instfiles page, the progressbar no longer appears after the first time the plguin is called.