Archive: Script error problems


Script error problems
New to NSIS...I am trying to use the script found here Quote:


but get this error...

Function: "myPreInstfiles"
Call "RestoreSections"
SetAutoClose: true
FunctionEnd
Function: "CheckInstalledJRE"
MessageBox: 0: "Checking Installed JRE Version"
Push: 1.6.0
Call "DetectJRE"
MessageBox: 0: "Done checking JRE version"
Exch($0,0)
StrCmp "$0" "0" equal=NoFound, nonequal=
StrCmp "$0" "-1" equal=FoundOld, nonequal=
Goto: JREAlreadyInstalled
MessageBox: 0: "Old JRE found"
Error: unterminated string parsing line at D:\TGDTJINSTALLER\installer.nsi:216
Error in script "D:\TGDTJINSTALLER\installer.nsi" on line 216 -- aborting creation process

http://nsis.sourceforge.net/wiki/New_installer_with_JRE_check_%28includes_fixes_from_%27Simple_installer_with_JRE_check%27_and_missing_jre.ini%29

Line 217 is supposed to be part of line 216 (it is quite long and the wiki must have split it). Just join those two lines together and recompile. The same thing happened again about 8 lines farther down. Join those lines too.


Thanks for the help! I see that now. That particular script has a few to many popups. I am trying to use the original version and am runing into a wall with it. First of all I took out all of the breaks that were put in it from posting the code, I think I got all of them. Second down towards the end is a variable called TEMP3. It isnt declaired at the top so I declaired that...it still wont detect my version of Java correctly. I have the JDK 1.6...it just comes up No JRE installed...can someone look at this and tell me if I should have not declaired teh TEMP3 variable and changed it to something else or if I have missed an improper break somewhere....


Here is my attachment..wouldnt let me attach it when I was editing my post

I also get these warnings...

3 warnings:
label "InstallJRE" not used
label "ExitInstall" not used
Variable "MUI_TEXT" not referenced, wasting memory!


All those TEMPx are defines not vars, though there are pieces of code where you use them as vars $TEMPx instead of defines ${TEMPx}.
EDIT: Sorry, forget it, I'm not able to follow the structure of this script.


LOL, the problem is I can get neither script to run...Neither of them pic up the 1.6 install...actually the one I have attached here picks it up, but it still says I need to install it...