bradharding
4th April 2007 04:23 UTC

Mui_header_transparent_text
Hi!

I've found that when using ModernUI and defining MUI_HEADER_TRANSPARENT_TEXT, the header text and subtext flicker quite badly with each page change.

I've discovered, however, that by changing the following code starting at line 187 of Contrib\Modern UI\System.nsh...

!macro MUI_HEADER_TEXT_INTERNAL ID TEXT

  GetDlgItem $MUI_TEMP1 $HWNDPARENT "${ID}"

  !ifdef MUI_HEADER_TRANSPARENT_TEXT

    ShowWindow $MUI_TEMP1 ${SW_HIDE}

  !endif

  SendMessage $MUI_TEMP1 ${WM_SETTEXT} 0 "STR:${TEXT}"

  !ifdef MUI_HEADER_TRANSPARENT_TEXT

    ShowWindow $MUI_TEMP1 ${SW_SHOWNA}

  !endif

!macroend

...to this...

!macro MUI_HEADER_TEXT_INTERNAL ID TEXT

  GetDlgItem $MUI_TEMP1 $HWNDPARENT "${ID}"

  !ifdef MUI_HEADER_TRANSPARENT_TEXT

    LockWindow "on"

    ShowWindow $MUI_TEMP1 ${SW_HIDE}

  !endif

  SendMessage $MUI_TEMP1 ${WM_SETTEXT} 0 "STR:${TEXT}"

  !ifdef MUI_HEADER_TRANSPARENT_TEXT

    ShowWindow $MUI_TEMP1 ${SW_SHOWNA}

    LockWindow "off"

  !endif

!macroend

...the flicker goes away nicely.

Is it possible for this to be changed? Am I even requesting this change in the right way? Or is there some other way I can achieve the same thing in my own code?

Thanks in advance.

Regards,
Brad. :)

bnicer
4th April 2007 11:22 UTC

Fantastic! Super cool. There can't be a better way, can there?

bradharding
6th April 2007 00:33 UTC

Not that I know of. This way works well.
Joost? Or the powers that be? Can this change please be made to the Modern UI code?

kichik
8th April 2007 17:14 UTC

The right place is the patch tracker. I'd upload it now but CVS is down :(

bradharding
8th April 2007 23:17 UTC

Thanks, Kichik!

The CVS appears to be back up now, so I've submitted a new request (#1696610) in the patch tracker.

I've been using the wonderful NSIS for over 4 years now (on the same project :eek: ), so it'd be great if I were able to contribute.

Joel
9th April 2007 01:54 UTC

Originally posted by bradharding
I've been using the wonderful NSIS for over 4 years now (on the same project :eek: ), so it'd be great if I were able to contribute.

Try for 6 years ;) Since 1.1 :p