Archive: Version Tab empty after upgrading from NSIS 2.18 to 2.28


Version Tab empty after upgrading from NSIS 2.18 to 2.28
Hi all,

I have in my script the following code:


VIProductVersion "${CI_NSIS_FILENAME_PROPERTY_VERSION}"
VIAddVersionKey /LANG=${LANG_ENGLISH} ProductName "${PRODUCT_NAME}"
VIAddVersionKey ProductVersion "${PRODUCT_VERSION}"
VIAddVersionKey /LANG=${LANG_ENGLISH} CompanyName "${PRODUCT_PUBLISHER}"
VIAddVersionKey /LANG=${LANG_ENGLISH} FileVersion "${PRODUCT_VERSION}"
VIAddVersionKey /LANG=${LANG_ENGLISH} FileDescription "${PRODUCT_NAME} ® File"
VIAddVersionKey /LANG=${LANG_ENGLISH} LegalCopyright "© ${PRODUCT_PUBLISHER}. All rights reserved."


This was working fine while having NSIS 2.18 installed. I upgraded NSIS to 2.28 a while ago and the Version Tab now is completely empty, even though the code hasn't change in this part.

Can smbd tell me what am I doing wrong?

Thx,
Viv

What I also noticed is that I get the following 3 warnings:


Generating version information for language "0000-English" without standard key "FileVersion"
Generating version information for language "0000-English" without standard key "FileDescription"
Generating version information for language "0000-English" without standard key "LegalCopyright"


but I don't really understand what they mean?

Thanks,
Viv

OK, I found in another thread kichik's answer: "Add /LANG=${LANG_ENGLISH} for ProductVersion as well. If you don't, it creates another version block for language 0 - the default English language. But as you don't specify FileVersion, FileDescription and LegalCopyright for that version, it complains."

Indeed by doing this change the Version Tab is not empty anymore :)

Thx,
Viv