Sheik
11th June 2008 19:10 UTC

BUG/Missing line in makensis.nsi script
Hi all,

There is a missing line in the makensis.nsi script.

Specifically, in the "Function PageReinstall" function.

There is:
nsDialogs::Create /NOUNLOAD 1018

But there is no "Pop" to grab the resulting value off the stack.

Per the docs of nsdialogs:

The first call must always be to nsDialogs::Create. It will create a new dialog in the page and return its HWND on the stack. The result must be popped from the stack to prevent stack corruption. If the result is error, the dialog couldn't be created.

Afrow UK
11th June 2008 19:44 UTC

Although it is good practice to always keep the stack clean, this isn't going to cause any problems in that script.

Stu

Sheik
12th June 2008 01:37 UTC

Hi Stu,

Sure.

I was just thinking that since we point people to makensis.nsi as a good example of a real world installer, that the code should be as close to bug/error free as possible. =)

kichik
12th June 2008 19:09 UTC

Thanks, fixed.