Speed78
1st December 2008 23:08 UTC

Bug: StrCmp + MUI_LANGDLL_DISPLAY
Hello,

I´ve a problem with the following code in onInit:

---------------
StrCmp $IsUpdate False +1 +2
!insertmacro MUI_LANGDLL_DISPLAY
---------------

I want to show the language dialog if the installation is not an update. But it doesn´t matter which value $IsUpdate has.

If the variabel $IsUpdate is true or false the code "!insertmacro MUI_LANGDLL_DISPLAY" will be executed every time.

The next code works, but it is not really correct because the last line will be skipped if there is any code:

---------------
StrCmp $IsUpdate False +1 +3
!insertmacro MUI_LANGDLL_DISPLAY
---------------


This works to correctly without any problems:

---------------
StrCmp $IsUpdate False ShowLanguageDialog DontShowLanguageDialog

ShowLanguageDialog:
!insertmacro MUI_LANGDLL_DISPLAY

DontShowLanguageDialog:
---------------

Is the first version a bug?

Best regards

Rainer

Joel
1st December 2008 23:43 UTC

StrCmp $IsUpdate False +1 +2

Anders
2nd December 2008 00:49 UTC

you can't do relative jumps over a macro, you don't know how many instructions the macro has, so you must use labels or even better, logiclib.nsh:

${If} $IsUpdate == "False"
!insertmacro xxxxx
${EndIf}

Speed78
2nd December 2008 17:46 UTC

Hello,

yes you are right. I though that +1 is a relative jump so that the macro code should be ignored. Now I use Labels...

Kind regards

Rainer