Archive: UninstallIcon issue in 2.43


UninstallIcon issue in 2.43
Compilation of non-MUI scripts fails if uninstaller code is present and Icon is specified but UninstallIcon is not:


OutFile "NSIS243_test.exe"

Icon "icon.ico"
;UninstallIcon "icon.ico"

Function .onInit
WriteUninstaller $TEMP
Abort
FunctionEnd

Section Blank
SectionEnd

Function un.onInit
Abort
FunctionEnd

Section un.Blank
SectionEnd


NSIS pre-2.43 will compile this script normally but 2.43 will return:
Error generating uninstaller icon: invalid icon size (possibly compressed icon) -- failing!
Perhaps this is an intentional change, but it's not documented and I would also expect the compiler to appear less "confused" about it, so I'm reporting it. I compiled on XP.


Another thing: GetSystemDefaultLangID() still misbehaves on Vista. I reported this a while ago: thread

already reported @ http://sourceforge.net/tracker/index...49&atid=373085

I know there was a change to the resource editor, probably related to that


Get the fixed version at:

http://stashbox.org/390882/makensis-2572035.zip