Please add an optional no text CRC progress dialog

Archive: Please add an optional no text CRC progress dialog

CrushBug
17th January 2011 21:43 UTC

Please add an optional no text CRC progress dialog
Greetings:

I have asked this in the past a few times and have been told that I just need to modify the NSIS source code. Unfortunately, our legal department does not allow us to touch the source code, so that option is out.

The issue is that the initial "Setup is validating... 99%" (sorry, I know the text is incorrect) is in English with no option for localization nor for individual installer to adjust that text.

Would it be possible to add an option for suppressing this text into the NSIS installer settings? The result would be the installer icon and a numerical percentage only on that dialog that should be self-evident to the customer as to what is going on.

Is there any other ideas that anyone else has on resolving this? Turning off the CRC is pretty much out of the question as it could lead to installing corrupt data.

Derek

Anders
17th January 2011 23:29 UTC

Did you try hex editing the stub? Replace the text with just %d%% (and a ending 0)

CrushBug
18th January 2011 02:30 UTC

Sorry, I don't know all the files off hand. What is the file name of the stub? Thanks for the suggestion, I look forward to trying it out.

Anders
18th January 2011 07:00 UTC

NSIS\stubs

Something like http://img46.imageshack.us/img46/8029/stub.png

CrushBug
18th January 2011 22:45 UTC

Thanks Anders, I will take a shot at this.

Back to the original issue. We have been joyfully using NSIS for about 8 years now and this is one of the issues that our Localization QA and Cert always ding us on and we have to fight back with "Cannot Fix".

Do you think that this is something that could be fixed natively within NSIS in some manner? Something like adding a new stub "lzma_notext" and SetCompressor support?

Afrow UK
19th January 2011 00:15 UTC

Why not get your coders to submit a patch? Or would your legal department not allow that?

Stu

CrushBug
19th January 2011 00:57 UTC

We are not allowed to download the source code, thus we are blocked from that as well.

I did find the string "verifying installer: %d" in the "lzma" stub but I could not find the string "Please wait while Setup is loading..." so hex editing the stub would only help with one part. If that string is stored elsewhere, please let me know and I would be willing to give it a shot.

The primary concern is the message in the French market and the Toubon Law since those English strings are shown on a French OS.

Thanks to both of you for responding on this matter.

Anders
19th January 2011 08:12 UTC

http://nsis.svn.sourceforge.net/view...37&view=markup shows the 6 hardcoded english strings, "verifying installer: %d%%" appears in all stubs, "unpacking data: %d%%" is only present when solid compression is used. I don't remember anything along the lines of "Please wait while Setup is loading..."

Afrow UK
19th January 2011 11:15 UTC

Please wait while Setup is loading... is in MUI only. Without checking it is probably hard coded in modern.exe.

Stu

Anders
19th January 2011 15:29 UTC

Originally posted by Afrow UK
Please wait while Setup is loading... is in MUI only. Without checking it is probably hard coded in modern.exe.

You are correct sir, thankfully it is easy to change that with ChangeUI and resource hacker

CrushBug
19th January 2011 17:43 UTC

Oh, ok, so this is a little more complicated and yes, we are using MUI2. Thanks again for your help.

I have searched through the files in my NSIS install directory and I cannot find the "Please wait while Setup is loading" string in modern.exe or any other files. Can either of you direct me where I should be looking or if I shouldn't be looking for plain text?

CrushBug
19th January 2011 17:50 UTC

Sorry, I forgot to search for text in wide format, so I did find "Please wait while Setup is loading..." in modern.exe

A hacking I will go... a hacking I will go... :)

Afrow UK
19th January 2011 19:56 UTC

You could have used Resource Hacker to modify modern.exe.

Stu

DrO
19th January 2011 20:01 UTC

funny that, hacking the exe is fine but doing it the proper way in the code isn't allowed (sounds like you legal department have too many bugs of their own).

-daz

CrushBug
19th January 2011 21:46 UTC

You could have used Resource Hacker to modify modern.exe.

I will, once I get back to this.

funny that, hacking the exe is fine but doing it the proper way in the code isn't allowed

At this point, it hasn't gone back to legal for approval (and I doubt they would give it). I am just trying to see if resolving this myself is even possible.

Their core issue they have has to do with downloading open source source code. There aren't that many problems with using pre-compiled open source solutions (NSIS for example =).

But to get back to the original point, it would certainly be beneficial if NSIS offered at least a No Text options for these messages natively. Even better if they were fully localized. Considering the massive and awesome localization support that NSIS offers (I have made internal version of our installers in pirate and wookie) the fact that this message is hard coded in English feels like a tragic oversight.

Anders
20th January 2011 18:00 UTC

They can't be localized since the language stuff has not been loaded when that dialog is open

CrushBug
20th January 2011 18:39 UTC

Originally posted by Anders
They can't be localized since the language stuff has not been loaded when that dialog is open

Fair enough and that makes sense. At that point a no text option would get us out of trouble with loc and cert.

JamesBellinger
21st January 2011 02:39 UTC

Is there a reason those strings couldn't be localized by default for major languages? It would probably take under 1 KB.

CrushBug
21st January 2011 17:41 UTC

I think they could be, but the issue is more like there is no code in those stubs for OS system language detection. While the strings themselves could be small there would probably be challenges with detection and displaying the strings properly in all situations.