nels
17th October 2001 16:52 UTC

Patches
Hey Justin,

Since you are working hard on NSIS these days, I thought maybe you could include some patches to make it compatible with gcc. I attached patches.zip which contains:

-gcc_compat.txt : instructions to make NSIS compatible with gcc
-errors.txt : some errors I found in your sources

Note: These changes are for NSIS 1.58

Regards
Nels

DuaneJeffers
18th October 2001 03:47 UTC

Submit it to the NSIS Project House. I have created an NSIS Hack section. I just need your approval, then I will upload it, AND if you have an SourceForge Account, leave me your unix name and I will add you to the project (If you want to).

-Duane

nels
21st October 2001 00:23 UTC

Another 2
I (in fact, gcc :D) just found 2 errors in NSIS 1.60 beta:

File : script.cpp
Line : 2170
Error : No casting
Todo : Change add_string(line.gettoken_str(3)[0]?line.gettoken_str(3):"1023") to add_string(line.gettoken_str(3)[0]?line.gettoken_str(3):(char *)"1023")

File : script.cpp
Line : 2361
Error : No casting
Todo : Change add_data(filedata?filedata:"",len) to add_data(filedata?filedata:(char *)"",len)

For the rest, it compiles with no problem with gcc. Good work...

justin
21st October 2001 07:34 UTC

Fixed those two. Hmm, perhaps I should be using const char * more religously. Anyway.

-Justin