Comments on 1.63 beta?

justin
10th November 2001 06:45 UTC

Comments on 1.63 beta?
Just curious everybody, anybody have any comments/problems with NSIS 1.63 beta? I was worried that the changes could cause problems (hence the 'beta') but I haven't heard anything about it. Any successes/failures? I'd like to move it to non-beta if no problems have been found... :)

-Justin

locnar42
10th November 2001 08:01 UTC

I haven't seen anything wrong with the new version, but I do have one request.
Could you update the contrib directory with the newest copy of Install Options. You can grab it from http://installoptions.sf.net/io.zip

This version adds checkboxes & option buttons. It changed a bit of other source code, but nothing major.

Thanks.
michael

spanky
10th November 2001 10:28 UTC

1.63 seems to be solid. I carefully observed the installer for odd, unexpected behaivour but I did not find anything.
My script file weighs in at a hefty 16k. I think I am using every NSIS function available. If anything comes up you'll be the first to know.

Keep up the good work!

DuaneJeffers
10th November 2001 10:38 UTC

Holy Shit!!!!!! Did you just release a new version??? I get sick for a week and now this!!!!!! Well, I must go and download it.

-Duane

eccles
10th November 2001 12:59 UTC

Comments? Cheers for using my code :-)

Problems? There's a small bug in CEXEBuild::do_add_file I think. When using /r to recurse into subdirectories, the code added to double-up '$' symbols does not null-terminate the output string.

As for the changes to strings - when I was testing it I changed VAR_CODES_START to some silly value like 65 to highlight any strings that weren't being processed in the installer when they should and vice-versa. You might want to do the same for a final check.

Unfortunately I've not been able to use the later NSIS's for my installers at work as they are using a heavily customised version of 1.44. I keep meaning to have a go a re-doing the changes in the latest NSIS... (some of which are not needed anymore because new NSIS features can be made to do the same!)

Otherwise, it appears to be working great :-)

Dave.

pjw62
10th November 2001 18:20 UTC

Comments? Cheers for using my code aswell :)

Sorry about forgetting to comment out the printfs.. they were supposed to end up as #ifdefs but I forgot.

It seems fine, I built a few inistallers with custom icons and bitmaps etc and it seemed to work okay.

eccles
11th November 2001 00:09 UTC

NSIS 1.64 is here.. cool (what happened to 1.63 final?) :)

Ar.. that makes this feature request a bit late then :(

  static const char VarNames[] =
  ...
  "CMDLINE\0"       // 13
  ...

        ...
        case VAR_CODES_START + 13 : // CMDLINE
          lstrcpy(out, GetCommandLine());
          break;
        ...

Could something like that be added? My own selfish reasons for asking, of course ;) but come to think of it, maybe it could pave the way to transfering some of the uninstaller code for copying to the temp directory etc to NSIS script?!!!

Dave.

justin
11th November 2001 02:30 UTC

Quote:

Shore I'll put it in the queue for 1.65...
-j

Originally posted by eccles
NSIS 1.64 is here.. cool (what happened to 1.63 final?) :)

Ar.. that makes this feature request a bit late then :(

  static const char VarNames[] =
  ...
  "CMDLINE\0"       // 13
  ...

        ...
        case VAR_CODES_START + 13 : // CMDLINE
          lstrcpy(out, GetCommandLine());
          break;
        ...

Could something like that be added? My own selfish reasons for asking, of course ;) but come to think of it, maybe it could pave the way to transfering some of the uninstaller code for copying to the temp directory etc to NSIS script?!!!

Dave.