rainwater
28th January 2002 22:22 UTC

MakensisW Wrapper Update
I've updated makensisw again (v0.6). You can get the source here. Just extract the zip to your NSIS contrib directory (it will make a 'makensisw' directory). Most of the changes are minor changes:

- print correct usage if unable to execute compiler
- removed mingw warnings
- set title/branding before errors
- some docs changes
- Added Edit|Edit Script function

Rob

felfert
29th January 2002 00:02 UTC

Hi, Rob.

There's a design flaw with the edit feature:
The g_input_script variable is set after compilation. At this time the Text "Processing script..." might already be lost in the log buffer and thus no editing is possible. (My scripts here usually produce compiler output far beyond 32k).

I've corrected that (moved the check from EnableItems into LogMessage) and while i've been on it, added code for window-resizing as well as save/restore of window state on exit/startup.

I've attached patches for both issues.
-Fritz

PS: If you prefer a complete zip arch, drop me a mail.

rainwater
29th January 2002 00:49 UTC

Good call. I'll add the fix for the edit script and post it soon. The only thing i changed was i didnt check for the script once it was found.

I look at the resize code (it may not make it in the next release).

Rob

rainwater
29th January 2002 05:47 UTC

I've updated makensisw with your changes. I had to make a few resize changes to your patch in order for everything to line up correctly. I also fixed the enabling of some menuitems that shouldnt have been. Here's the changes:

- Edit Script should now work for output>32k
- Added resize support (thanks to felfert)
- Added window position saving (thanks to felfert)
- Disable some items when exec of makensis failed

Download here

Rob

felfert
29th January 2002 12:10 UTC

Cool! :) Works great. ... and thanks for the credits.

Ciao
-Fritz

bcheck
29th January 2002 16:54 UTC

min size
how about enforcing a min size to avoid jerks like me from having an ugly window:

case WM_GETMINMAXINFO:
{
((MINMAXINFO*)lParam)->ptMinTrackSize.x=350;
((MINMAXINFO*)lParam)->ptMinTrackSize.y=175;
}
// fall thru
case WM_ENTERSIZEMOVE:
{
GetClientRect(g_hwnd, &resizeRect);
return TRUE;
}

rainwater
29th January 2002 17:16 UTC

I guess that is pretty ugly. No problem, I'll add it and it will be in the next release.

rainwater
29th January 2002 19:03 UTC

As usual you can find the updated source here. The latest version has the windows contraints fix.

Rob