Add this to 1.99? - NSIS Forums

LIGHTNING UK!
5th May 2002 14:42 UTC

Add this to 1.99?
Hi,

Any chance of getting a couple of bits added to the code in the next version?

Here is what I have in mind:

The browse dialog box is the old style, even on the newer os's. This means, amongst other things, that you dont get the 'right click' explorer type context menu (which a lot of people like). Can you change the following:

bi.ulFlags = BIF_RETURNONLYFSDIRS;
to
bi.ulFlags = BIF_RETURNONLYFSDIRS | BIF_VALIDATE | IF_NEWDIALOGSTYLE;

The validation doesnt bit doesnt work properly for some reason, even with that flag set, so it is then necessary to added the following to the call back function:

============

else if (uMsg==BFFM_SELCHANGED)
{
TCHAR szDir[MAX_PATH];
if(!SHGetPathFromIDList((LPITEMIDLIST) lParam ,szDir))
{
// Disable the OK button if the currently selected item isnt a valid path
SendMessage(hwnd, BFFM_ENABLEOK, 0, FALSE);
}
}

============

Thanks - if you do it ;-)

P.S, I think the xp support should be ON by default. For the sake of 1k, its more hastle than its worth to leave it off and make us all change it and compile the code ourselves.
I also find it strange that when you select a destination directory, it automatically appends the existing path (final directory) to it. Im sure no other program (or at least not many) work in this way.

Just my 2p worth :-)

Keep up the great work.

SmartyMan
7th May 2002 23:22 UTC

Re: Add this to 1.99?

Originally posted by LIGHTNING UK!
I also find it strange that when you select a destination directory, it automatically appends the existing path (final directory) to it. Im sure no other program (or at least not many) work in this way.

I like this feature, because that what I always have to do manually when installing software (change the path but keep the Product name as folder)

justin
14th May 2002 07:03 UTC

Re: Add this to 1.99?

Originally posted by LIGHTNING UK!
I also find it strange that when you select a destination directory, it automatically appends the existing path (final directory) to it. Im sure no other program (or at least not many) work in this way.

From makensis.htm (under InstallDir):

Sets the default installation directory is. See the variables section for variables that can be used to make this string (especially $PROGRAMFILES). Note that the part of this string following the last \ will be used if the user selects 'browse', and may be appended back on to the string at install time (to disable this, end the directory with a \ (which will require the entire parameter to be enclosed with quotes)). If this doesn't make any sense, play around with the browse button a bit.

-Justin

LIGHTNING UK!
14th May 2002 07:27 UTC

Justin,

It's ok, I just commented out the bit of code that does the appending.

Hows about my other ideas though? Any chance you can put them in the next version?

sdbarker
14th May 2002 14:09 UTC

Re: Add this to 1.99?

Originally posted by LIGHTNING UK!
P.S, I think the xp support should be ON by default. For the sake of 1k, its more hastle than its worth to leave it off and make us all change it and compile the code ourselves.

I disagree. I personally would have to recompile to disable XP support. Granted I generally re-compile anyway, but that 1k is precious to me. :)

-Scott

Zaraza
14th May 2002 17:45 UTC

Can't we all get along?
Maybe those of us without VC++ can get an alternate compiled download, e.g. NSIS 1.98 XP Edition? :D

When doing an install for a 20MB app I will gladly live with an extra 1KB.

sdbarker
14th May 2002 18:02 UTC

But, when doing an install for < 100k app, I'd rather not have that extra 1k and help keep it sub-100.

-Scott

kichik
14th May 2002 18:50 UTC

Re: Can't we all get along?

Originally posted by Zaraza
Maybe those of us without VC++ can get an alternate compiled download, e.g. NSIS 1.98 XP Edition? :D

When doing an install for a 20MB app I will gladly live with an extra 1KB.

I am currently working on a NSIS mod that will enable you to add XP support on script compile time with no need of VC++. A version that works only on NT is already available. If you want I will send it to you.

KiCHiK

LIGHTNING UK!
14th May 2002 19:21 UTC

1k isnt even 1k! It will still probably occupy more than that due to the cluster size on the drive you are using. I dont even really see the need for an installer is the program/files you are installing are < 100k....you might as well just write a batch file. No end user would care about 1k, even on the slowest modems it wouldnt take anywhere near a second to download. Now if you had 100k medium and with the XP support it came out to 101k then I could understand but otherwise, whats the big deal!!!

sdbarker
14th May 2002 20:17 UTC

But it takes UP 1k on disk, at least, yes because of cluster size.

The need is to not have the useless bloat in there. 1k of bloat is still bloat.

I know it would take less than a second.

Have you polled all of the end users to find out if they would care or not?

The big deal is that it's the principle of the thing. That 1k is not needed. That's why I recompile NSIS in the first place, to remove support for all of the functions that I don't need. Part of the beauty behind this piece of software is how exceptionally advanced it is for it's size. I don't wish to compromise that.

-Scott