Oops, last minute addition killed it. Here's one that does show it on top. What do you mean by "Install options fail again here"?
The Banner.dll attached crashes if destroy is called a very short period of time after show, so don't use it except for checking that the dialog shows on the foreground.
Banner doesn't show
38 posts
Kichik, I tried using your revised banner.dll on my Win98SE system, using the 9 September (19:44 GMT) CVS snapshot. The Contrib\Banner\Example.nsi script worked OK but when I tried my MUI-based script, the installer crashed.
In my installer I have a custom page 'leave' function which displays a banner for 5 seconds. No banner appeared then after about 5 seconds I got the following error message:
THE-PROGRAM caused an invalid page fault in
module <unknown> at 0000:00cc102c.
Registers:
EAX=00000000 CS=0187 EIP=00cc102c EFLGS=00010202
EBX=00ddfa90 SS=018f ESP=00ddfa40 EBP=00ddfa5c
ECX=00000000 DS=018f ESI=00008ab4 FS=1b07
EDX=00008ad0 ES=018f EDI=00ddfa44 GS=57ff
Bytes at CS:EIP:
Stack dump:
bff7363b 00000724 00000046 00000000 00ddfad0 8a8e57ff 0000018f 00ddfa70
bff94407 57ff8ab4 000057ff 00000000 bff719b8 00008aae 00ddfd30 bff7186d
I'm not sure if 5 seconds counts as "a very short period of time" so the crash may not be a problem. However the banner did not appear (expected to see an icon and two lines of text)
In my installer I have a custom page 'leave' function which displays a banner for 5 seconds. No banner appeared then after about 5 seconds I got the following error message:
THE-PROGRAM caused an invalid page fault in
module <unknown> at 0000:00cc102c.
Registers:
EAX=00000000 CS=0187 EIP=00cc102c EFLGS=00010202
EBX=00ddfa90 SS=018f ESP=00ddfa40 EBP=00ddfa5c
ECX=00000000 DS=018f ESI=00008ab4 FS=1b07
EDX=00008ad0 ES=018f EDI=00ddfa44 GS=57ff
Bytes at CS:EIP:
Stack dump:
bff7363b 00000724 00000046 00000000 00ddfad0 8a8e57ff 0000018f 00ddfa70
bff94407 57ff8ab4 000057ff 00000000 bff719b8 00008aae 00ddfd30 bff7186d
I'm not sure if 5 seconds counts as "a very short period of time" so the crash may not be a problem. However the banner did not appear (expected to see an icon and two lines of text)
It always worked when the NSIS window already existed, that doesn't matter. I need to know if it works on .onInit. Should have been more clear on that, sorry.
OK, here's one that's not supposed to crash anywhere. It turned up well on all of my tests, .onInit and not .onInit. Please let me know if it crashes or doesn't behave as expected anywhere.
It also has some of Brainsucker's additions, namely the ability to hide the taskbar icon (set main text to "") and the ability to set a different text for the window and IDC_STR (/set 1030 "test" "another text"). I have not added the ability to disable the window because that's already possible with the built-in EnableWindow NSIS script instruction.
It's still full of debug information, so I don't recommend you use it in public installers (unless it's beta too, heh).
It also has some of Brainsucker's additions, namely the ability to hide the taskbar icon (set main text to "") and the ability to set a different text for the window and IDC_STR (/set 1030 "test" "another text"). I have not added the ability to disable the window because that's already possible with the built-in EnableWindow NSIS script instruction.
It's still full of debug information, so I don't recommend you use it in public installers (unless it's beta too, heh).
Kichik, sorry I missed the part about .onInit. After downloading the latest version of your DLL, I modified .onInit to display a banner for 5 seconds (the same banner as my custom page's 'leave' function).
The .onInit banner appeared (with the icon and two lines of text) when I started the installer. But when I reached the part where the custom page 'leave' function displays a banner, no banner appeared. This time no error appeared and after 60 seconds I tried Ctrl-Alt-Del and found that my installer was listed as "(Not responding)".
Brainsucker's DLL from banner1.zip works perfectly in my installer (in .onInit and in the custom page's 'leave' function).
I'm using Win98SE and the 9 September (19:44 GMT) CVS snapshot and an MUI-based installer script.
The .onInit banner appeared (with the icon and two lines of text) when I started the installer. But when I reached the part where the custom page 'leave' function displays a banner, no banner appeared. This time no error appeared and after 60 seconds I tried Ctrl-Alt-Del and found that my installer was listed as "(Not responding)".
Brainsucker's DLL from banner1.zip works perfectly in my installer (in .onInit and in the custom page's 'leave' function).
I'm using Win98SE and the 9 September (19:44 GMT) CVS snapshot and an MUI-based installer script.
Thanks, fixed.
Kichik, your latest banner.dll now works OK in .onInit and in my custom page 'leave' function.
OK, uploaded new Banner. Thanks for helping us test.