typos in the docs ...

"The dog has a bone, and the dog has a phone". I don't see anything wrong with that (apart from having a phone lol!)

If we were to put 'have' in there, we'd have to change it to:
"The dog has a bone, and the dog used to have a phone"; in order for it to make sense, but then that changes it completely (to past tense).

The only thing that sounds bad when used more than once in the same sentence is 'and' (which is where we use commas).

Hope that makes sense 🙂

-Stu

It appears you were right. However, while checking it, I got a suggestion for a better sentence which I eventually used.

NSIS boasts the smallest overhead available while still providing a lot of options thanks to its powerful scripting language and support of external plug-ins.

I found a small error at the end of Chapter 4 contents (HTML error):


-Stu

And the error is? Don't leave me hanging 🙂

Sorry Kichik, I couldn't reproduce the HTML error at home. It must have been the college computers at fault (with their stupid content blockers which probably meant only half the page was loading or something.)

-Stu

4.12 Silent Installers/Uninstallers
[...]The above example will copy the value the user passes on after /USRNAME= into $0.[...]

I think /USRNAME must be changed to /USERNAME.

Thanks, fixed.

I found a small error at the end of Chapter 4 contents (HTML error):

http://nsis.sourceforge.net/Docs/Chapter4.html

-Stu

ran the file through html-tidy from w3c.
found two fixable mistakes:

<address>

</address>

<a href="http://sourceforge.net"><img border=0 src="http://sourceforge.net/sflogo.php?group_id=22049&amp;type=1" alt="SourceForge Logo"></a></body>

> the adress tag is emtpy
> the img tag is not closed.

there were lots of other warnings too, but i dont think, they make sense.

If you are unsure how to close the img tag, it should be:
<img border=0 src="http://sourceforge.net/sflogo.php?group_id=22049&amp;amp;type=1" alt="SourceForge Logo" />

Not to mension & should be &amp;amp; too (if it isn't already).

-Stu

In section 8 of the MUI Readme, there is:

For the uninstaller, use the MUI_UNFUNCTION_DESCRIPTION_BEGIN and MUI_UNFUNCTIONS_DESCRIPTION_END macros.

Which should be MUI_UNFUNCTION_DESCRIPTION_END, no s.

-auz

Thanks, fixed.

4.8.1.21 InstallDir:
"Sets the default installation directory is." remove is (doh)

Thanks, fixed.

4.9.14.5 FindWindow

FIndWindow $0 "my window class" "my window title"
It should be Findwindow

4.9.14.1 BringToFront
... If the user if working with another ...

I think it should be - If the user is working

Thanks, fixed.

4.7.2.1.6 .onMouseOverSection
STR: prefix is missing from lparam (in example code)

the docs also needs to be more clear about the description label, eg you actually have to use resource hacker to add a label (or use a existing label like in the ugly hack i did here: http://www.rafb.net/paste/results/XTG9Pd58.html )

Thanks, fixed.

And what about

Variables

Variables start with $. User variables should be declared and are case-sensitive.

Is this mean - variables names are case-sensitive?
This code work fine:

var vv1

...

StrCpy $Vv1 "1 string 1"

MessageBox MB_OK "$vV1"

Is this typo, or NSIS bug, or I misunderstood something in docs?

Just a relic from the old days when variables were case sensitive. Fixed, thanks.

This isn't really an issue with the manual, but I noticed that there's no shortcut to the InstallOptions manual in the start menu shortcuts group.
Or is it just me?

-Stu

Thanks, fixed.

file:
INSTALL

This is a trimmed version of Appendix F of the documentation.

should be Appedix G

Appedix? 😉

-daz

In the modern UI readme, under 3. Pages > Page Settings > Finish Page Settings > MUI_FINISHPAGE_RUN_FUNCTION:

Call a function instead of executing an application (define MUI_FINISHPAGE_RUN without parameters). You can use the function to exectute multiple applications or you can change the checkbox name and use it for other things.

-Stu

Appedix?

well, yea ....
you pwned me 😁

Thanks, fixed.

Typos

I've attached the typos I found. Hope it helps.

-J

Diff File

Oops, I just saw the message on the first page of this thread that asks for large corrections to be presented as a patch. I can't edit my post above to delete it, but anyway...

I have attached a diff to this message, with all the corrections listed in the above message, plus one or two others I ran across. I'm not sure if the way I did it is the preferred way, but if not - just let me know and I'll change it.

I attached it as .txt because the forum doesn't allow the .diff extension. Thanks,

-J

Awesome, thanks! All committed.