Could somebody see what is wrong with my script

36 posts

VegetaSanFebruary 7, 2004 at 3:32 PM#

Could somebody see what is wrong with my script

Could you please look at my script
(At the bottom of the script)

I want that my installer automaticly sets the .ogm extension to open with Media Player Classic

VegetaSanFebruary 7, 2004 at 3:38 PM#

Script Information >>>>>

location "mplayercXP.exe"
$PROGRAMFILES\a-S Codec Pack\mplayercXP.exe

VegetaSanFebruary 7, 2004 at 4:58 PM#

>>This is the IMPORTANT Section of the script<<

;------------------------------------------------

Section

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic XP OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player Classic\mplayercXP.exe\mplayercXP.exe,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" \
'$PROGRAMFILES\a-S Media Player Classic\mplayercXP.exe "%1"'
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit" "" "Media Player Classic XP OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit\command" "" \
'$PROGRAMFILES\a-S Media Player Classic\mplayercXP.exe "%1"'
!undef Index
; Rest of script

SectionEnd
;-----------------------------------------------

WHAT IS WRONG?******************************???

JoelFebruary 7, 2004 at 5:50 PM#

What's the error?

VegetaSanFebruary 7, 2004 at 5:58 PM#

It doesnt give any error. It just dont work

VegetaSanFebruary 7, 2004 at 6:12 PM#

Lobo King did you see my script. Could you take a look at that please and look what is the error THANKS

VegetaSanFebruary 7, 2004 at 8:37 PM#

Sorry it was Lobo Lunar

VegetaSanFebruary 7, 2004 at 8:38 PM#

Could Somebody help me ******???

question = look above this Thread

VegetaSanFebruary 7, 2004 at 8:48 PM#

Section
;----------------------------------------------------------
!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$SYSDIR\mplayercXP.exe,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" \
'$SYSDIR\mplayercXP.exe "%1"'
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit\command" "" \
'$SYSDIR\mplayercXP.exe "%1"'
!undef Index

SectionEnd
;----------------------------------------------------------

Location File "$SYSDIR\mplayercXP.exe"

What is wrong ******************************************

Joost VerburgFebruary 7, 2004 at 8:50 PM#

You don't have to shout every minute. And we also have a button to edit posts.

Try putting quotes around paths with spaces using $\"

VegetaSanFebruary 7, 2004 at 8:50 PM#

Note: The Compiler doesn't give a error (I can run the installer)

but .ogm files will not open with Media Player Classic

VegetaSanFebruary 7, 2004 at 8:52 PM#

what do you mean ???

example please, thanks

Joost VerburgFebruary 7, 2004 at 9:34 PM#

It this case, the folder names contain spaces so you should put quotes around the whole path, for example:

"$PROGRAMFILES\a-S Media Player Classic\mplayercXP.exe"

VegetaSanFebruary 8, 2004 at 9:38 AM#

I am getting craZY I dont know why

;----------------------------------------------------------

Section

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" \
'$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe "%1"'
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit\command" "" \
'$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe "%1"'
!undef Index

SectionEnd

;--------------------------------------------------------

What is wrong ******??

The file is in "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe"

and it should set .ogm files to open with "mplayercXP.exe"

VegetaSanFebruary 8, 2004 at 9:56 AM#

Got it allmost it gives a error insted of just skipping it

THIS IS THE ERROR
WriteRegStr expects 4 parameters, got 5.
Usage: WriteRegStr rootkey subkey entry_name new_value_string
root_key=(HKCR|HKLM|HKCU|HKU|HKCC|HKDD|HKPD)
Error in script "C:\Documents and Settings\GokuSan\Bureaublad\ML + Wind and .NSI" on line 834 -- aborting creation process

and this is line 834 :
"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe "%1"'

what is wrong ??

please write the whole code down

kichikFebruary 8, 2004 at 11:03 AM#

You should quote the path inside the entire parameter:

WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'

VegetaSanFebruary 8, 2004 at 11:34 AM#

Still doesnt work

ERROR :
WriteRegStr expects 4 parameters, got 9. Wind and .NSI" on line 834 -- aborting creation process

SCRIPT
Section

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" ;,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" \
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit\command" "" \
"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe ; "%1"'
!undef Index

SectionEnd

Line 834 :
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'

kichikFebruary 8, 2004 at 11:39 AM#

WriteRegStr HKCR "mplayercXP.OGMFile\shell" "open" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'

VegetaSanFebruary 8, 2004 at 11:50 AM#

The code you gave me is better but not good enough

ERROR
WriteRegStr expects 4 parameters, got 8.
on line 834 -- aborting creation process

Line 834
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "open" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'

kichikFebruary 8, 2004 at 11:56 AM#

You must be copying it wrong. It works fine here.

VegetaSanFebruary 8, 2004 at 12:05 PM#

Nope I dont know why :::

Section

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" ;,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" \
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "open" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit\command" "" \
"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe ; "%1"'
!undef Index

SectionEnd

Could you look at this maybe there is something wrong with the other lines

kichikFebruary 8, 2004 at 12:09 PM#

You have a backslash on the line before. That means the next line will be appended to it. Remove the backslash.

VegetaSanFebruary 8, 2004 at 12:25 PM#

ERROR ON LINE 833
;LINE 832
"${Index}-Skip:"
;LINE 833
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" ""

ERROR =
WriteRegStr expects 4 parameters, got 2.
on line 833 -- aborting creation process

ONoTHER ErroR , Man this never stops

WHOLE SCRIPT :

Section

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" ; ,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" ""
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "open" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\edit\command" "" \
"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe "%1"'
!undef Index

SectionEnd

kichikFebruary 8, 2004 at 12:30 PM#

It would have never started had you only changed what's needed.

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'
!undef Index

VegetaSanFebruary 8, 2004 at 12:47 PM#

If this is the script code then it isnt right. I can run the installer succsesfully. But when I open .ogm files then it will open with Windows Media Player insted of "mplayercXP.exe"

Section

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'
!undef Index

SectionEnd

kichikFebruary 8, 2004 at 1:30 PM#

Have you tried rebootin? Have you made sure Windows Media Player didn't revert the change (open regedit.exe and look under HKCR\.ogm)?

VegetaSanFebruary 8, 2004 at 3:17 PM#

It wont work (it doesnt give a error but it doenst work)

[size=1]Section

DeleteRegKey HKLM "Software\Classes\.ogm\*.*"
!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'
!undef Index

SectionEnd

And is this right:
DeleteRegKey HKLM "Software\Classes\.ogm\*.*"

VegetaSanFebruary 8, 2004 at 5:16 PM#

SomeBody help (AND I DONT NEED KICHIK's HELP)

Joost VerburgFebruary 8, 2004 at 6:02 PM#

Can you post the values of all relevent registry keys and describe the behavior or error messages when opening the media file?

VegetaSanFebruary 8, 2004 at 6:24 PM#

I want that my installer sets .ogm files to open with
mplayercXP.exe insted of Windows Media Player How do I do that

I Have done this with this script.. I can Run the installer but when I open .ogm files then it still opens with Windows Media Player insted of mplayercXP.exe

Info :
FileName : "mplayercXP.exe"
Directory : "$PROGRAMFILES\a-S Media Player Classic"

Script
Section

!define Index "Line${__LINE__}"
ReadRegStr $1 HKCR ".ogm" ""
StrCmp $1 "" "${Index}-NoBackup"
StrCmp $1 "mplayercXP.OGMFile" "${Index}-NoBackup"
WriteRegStr HKCR ".ogm" "backup_val" $1
"${Index}-NoBackup:"
WriteRegStr HKCR ".ogm" "" "mplayercXP.OGMFile"
ReadRegStr $0 HKCR "mplayercXP.OGMFile" ""
StrCmp $0 "" 0 "${Index}-Skip"
WriteRegStr HKCR "mplayercXP.OGMFile" "" "Media Player Classic .OGM File"
WriteRegStr HKCR "mplayercXP.OGMFile\shell" "" "open"
WriteRegStr HKCR "mplayercXP.OGMFile\DefaultIcon" "" "$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe,0"
"${Index}-Skip:"
WriteRegStr HKCR "mplayercXP.OGMFile\shell\open\command" "" '"$PROGRAMFILES\a-S Media Player ClassicXP\mplayercXP.exe" "%1"'
DeleteRegKey HKCU "SOFTWARE\Classes\.ogm"
!undef Index

SectionEnd