Problem with 2.32 installer

Hi,

I was using 2.31, then eclipse told me to update to v2.32. Good. Download. Setup. Compile with new version... => code broken !!!

The installer didn't take care about the Plugins, Include, Docs, and Examples directories, and deleted all my additional plugins... 👎

Gal'

It also did for me on 2.32.

I read on release note that "Modern UI 2 beta: Fixed 3-line title on welcome/finish page"... that means there no need to add "!define MUI_WELCOMEPAGE_TITLE_3LINES" ? Because if I don't add it with compiler v2.32, I still face the problem.

Gal'

MUI_WELCOMEPAGE_TITLE_3LINES is still required. It was just fixed for MUI2.

Okay, thanks 😉

And what about that plugins?

Nothing new.

Isn't it installer issue?

Yes, makensis.nsi uses RMDir /r $INSTDIR\Plugins.

If you want to keep additional dirs/files in $INSTDIR\Plugins every time on new NSIS release install change selection "Uninstall first" - this case rmdir is not executed. This feature presents .. beginnig at least 2.0.

Yes, makensis.nsi uses RMDir /r $INSTDIR\Plugins.

It SHOULDN'T! There is one (my) installation Rule - installer should delete only files that were written by it. I was surprised after 2.32 (re)installation.

Don't choose to uninstall first.

Stu

I hope to annoy enough people with this feature so that someone finally picks up the glove and give makensis.nsi a facelift. Plus the usual more important stuff to do and the usual bad practice in installing custom plug-ins to the Program Files directory when there's !addplugindir. So - no, I'm not going to fix this.

We have a saying in my language: "Blacksmith's mare walks barefooted."

In my language it's: "the shoemaker walks barefooted". Funny how similar are those two 🙂

In these 42 sayings is only a few with different translations. The others are completly same in my (Czech) language.

Excuse me for a bit offtopic 😉