Skip to content
⌘ NSIS Forum Archive

Bug in macro UMUI_PAGE_ALTERNATIVESTARTMENU in UMUI

4 posts

HSorgYves#

Bug in macro UMUI_PAGE_ALTERNATIVESTARTMENU in UMUI

The functions "${PRE}" and "${LEAVE}" are responsible to react to an activation of "Do not create shortcuts". However they only disable the textfield and the treeview but not the "How the shortcuts will be created:" part (if available).

In lines 7393-7401 (old: 7393-7395) should be the following code [line 7393 changed, lines 7396-7401 added]:
StrCmp $MUI_TEMP1 "1" 0 +5
  !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field 2" Flags "DISABLED"
  !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field 3" Flags "NOTIFY|DISABLED"
  !ifdef UMUI_ALTERNATIVESTARTMENUPAGE_SETSHELLVARCONTEXT
    !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field ${ASMALLOPTFIELD}" Flags "DISABLED"
    !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field ${ASMCURRENTOPTFIELD}" Flags "DISABLED"
  !endif 
In lines 7423-7431 (old: 7417-7419) should be the following code [line 7423 changed, lines 7426-7431 added]:
StrCmp $MUI_TEMP1 "0" 0 +5
  !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field 2" Flags ""
  !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field 3" Flags "NOTIFY"
  !ifdef UMUI_ALTERNATIVESTARTMENUPAGE_SETSHELLVARCONTEXT
    !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field ${ASMALLOPTFIELD}" Flags ""
    !insertmacro INSTALLOPTIONS_WRITE "AlternativeStartMenu${ID}.ini" "Field ${ASMCURRENTOPTFIELD}" Flags ""
  !endif 
In lines 7495-7501 (old: 7483) should be the following code:
!ifdef UMUI_ALTERNATIVESTARTMENUPAGE_SETSHELLVARCONTEXT
  GetDlgItem $MUI_HWND $UMUI_TEMP3 1205 ;"Field 6" "HWND"
  EnableWindow $MUI_HWND $MUI_TEMP2
  GetDlgItem $MUI_HWND $UMUI_TEMP3 1206 ;"Field 7" "HWND"
  EnableWindow $MUI_HWND $MUI_TEMP2
!endif 
Look at the line numbers; empty lines are unfortunately not displayed!

Best Regards,
Yves
SuperPat#
This fix will be in the next update.

I had not done before because this option could also be used by the $DOCUMENT variable and by the SHCTX root_key which depends on the SetShellVarContext setting.
HSorgYves#
Problem solved in today's release. Thanks for your quick development!

Best Regards,
Yves