Skip to content
⌘ NSIS Forum Archive

Possible MUI2 Super Minor bug

2 posts

Squirre1#

Possible MUI2 Super Minor bug

I have dug through the code and believe I have found a very small bug in the MUI2 Finish.nsh file.

I was adding MUI_FINISHPAGE_TITLE_3LINES but for some reason my Title was running into my text. This ONLY occured when I displayed the rebootnow/rebootlater radio options.

Original Line 336:
        ${NSD_CreateLabel} 120u 45u 195u ${MUI_FINISHPAGE_TEXT_HEIGHT_BUTTONS}u "${MUI_FINISHPAGE_TEXT_REBOOT}"
Fixed Line 336:
        ${NSD_CreateLabel} 120u ${MUI_FINISHPAGE_TEXT_TOP}u 195u ${MUI_FINISHPAGE_TEXT_HEIGHT_BUTTONS}u "${MUI_FINISHPAGE_TEXT_REBOOT}"
Basically, it was making the finish text static and not allowing it to be dynamic in support of the MUI_FINISHPAGE_TITLE_3LINES define. So the text was not adjusting correctly whenever the reboot option was presented to the installer...