Aero plug-in

Originally Posted by Afrow UK View Post

I'm not sure what you are trying to do but you can't mix Aero with Windows controls without owner drawing them. I had to draw the navigation buttons myself to fix the transparency issue (and it still wasn't perfect until the last release). The problem is that the transparency key is black (and it has to be) and so all black objects (text etc.) will be rendered transparent.

Stu

this made the difference, not the colors

#old code

ShowWindow $HWNDPARENT 2

BringToFront

Aero::Apply ;causes infrequent crashes



#new code

Aero::Apply ;causes infrequent crashes

ShowWindow $HWNDPARENT 2

BringToFront

Just noticed this plug-in. Great stuff. Thanks for sharing 🙂

I haven't experienced any crashes. Please can you post a script which reproduces the problem.

Edit: and what is the minimize and bring to front for?

Stu

Branding text on WelcomeFinish page

First of all I would like to give you a big 👍 for the great work you have made with this plugin.

And my question 🙂 is ...
The branding text is displayed on WelcomeFinish page when Aero is activated; when Aero is deactivated, the branding text is hidden. I'm used to not have this branding text on the first and last page. Did you intend to have this branding text displayed while Aero is activated or it's a bug? Is there a way to not have it displayed on first&last page?

Thanks
Isawen

At the moment the branding text is either drawn or it isn't. It's not a static text control, it is simply drawn where the original static text used to be. Because of this, MUI does not hide/show it. I will fix it when I have time.

Stu

Originally Posted by Afrow UK View Post

Edit: and what is the minimize and bring to front for?

Stu

I'm guessing this fixes some kind of drawing bug...

1.0.0.5 - 9th July 2011
* Branding text now hidden when branding text static text control is hidden.

Stu

Is there any chance to have the branding text centered in "classic" UI?

Possibly but keep in mind there's a hidden Back button there so even if I do centre it it won't be centred in between Cancel and Close. The original branding text isn't centred IIRC it just happens to fit nicely for classic UI (when you have all 3 buttons).

Edit: It is in fact but still only centred between the 3 buttons.

Stu

Originally Posted by Afrow UK View Post

Possibly but keep in mind there's a hidden Back button there so even if I do centre it it won't be centred in between Cancel and Close. The original branding text isn't centred IIRC it just happens to fit nicely for classic UI (when you have all 3 buttons).

Edit: It is in fact but still only centred between the 3 buttons.

Stu

Yup, I know it's centered between the three buttons and still wouldn't be perfectly centered with only two buttons visible. Anyway, I think it looks better than glued to the left button. Also moving the buttons down by a few pixels wouldn't hurt (if possible).

Thanks 🙂

1.0.0.6 - 12th July 2011
* Fixed branding text not re-showing on DWM disable and re-enable.
* Centred branding text for classic UI.
* Nudged buttons down by 3 pixels for classic UI.

Night 🙂

Stu

Originally Posted by Afrow UK View Post

Night 🙂

Stu

Great 👍

not sure if it's just me (again?), but the glow effect on the left border seems cut off.

That's odd I don't get that. Are you using a modified UI? It uses the same left coordinate that the original branding text is which is 5 dialog units from the left according to Resource Hacker (modern.exe).

Stu

nope, using mui2. no special windows theme or alternate shell either, i tested the win7 standard theme as well. get the same when compiling Examples\makensis.nsi with added aero plugin.

Is that the latest plug-in version? You shouldn't have any branding text on the welcome/finish pages.

Stu

Just a side note:

With a none standard DPI setting (i.e. other than "96 dpi" aka "100%"), there is a strange border with Aero plug-in enabled.

Originally Posted by Afrow UK View Post

Is that the latest plug-in version? You shouldn't have any branding text on the welcome/finish pages.

Stu

true, i didn't use the latest version. i recompiled and there's no branding on the welcome page. can't say if anything else changed as i'm logged in via RDP (no aero!), will do so when i get home.

the branding text is no longer cut off when using the latest version!

Branding text overlapped by the Back button

Stu, if you set a big text for the branding text you should see that it's overlapped by the Back button.

I just started experimenting with this plugin. It looks good, but I found one oddity. If a link is added to the finish page, the text color of the link changes to black with a black line below and a black block to the right.

This is known bug - it is the same thing which Checkbox/Radiobuttons suffer too.
I use XPStyle off to remove this behaviour, but maybe Stu will know what to change in sources to remove it completely.

MUI2? This isn't the same as checkboxes/radiobuttons. Static texts should not have this problem, although a link may do (which is a static text with added effects) but that depends on the code behind it.

Stu

Strange. No such problem here:

Yeah that's why I think he might be using MUI1.

Stu

It is MUI2. I am using MUI_FINISHPAGE_LINK and MUI_FINISHPAGE_LINK_LOCATION for the finish page link.

Me too... 😕

I just tried adding the MUI_FINISHPAGE_LINK and MUI_FINISHPAGE_LINK_LOCATION to the "Aero ModernUI.nsi" example included with the plug in and got the same results. I had the logging build of NSIS, so to be sure that it was not something odd with it, I compiled the script with the normal ANSI NSIS 2.46 and still got the same results with both my script and the example with the finish page link added. My machine is Win7 x64 Pro, if that might make any difference.

I always use Unicode NSIS, if that matters.

I have been putting off installing Unicode NSIS. Perhaps I'll give it a try to see if it fixes it.