Uninstaller does not reboot if run from installer

cowwocJanuary 20, 2012 at 6:31 PM#

Uninstaller does not reboot if run from installer

My installer code runs the uninstaller (in .onInit) if it detects the software is already installed. Once the software finishes uninstalling, it continues with the installation.

I am using "Delete /REBOOTOK" to delete files in my uninstaller. If one of the files cannot be deleted, it asks the user to reboot the system.

1. If I intentionally lock a file, run the uninstaller directly, and the user agrees to reboot the system *does* reboot.

2. If I do the same, but launch the uninstaller from inside the installer, it does *not* reboot.

The installer is invoking the uninstaller using this code:

ExecWait '$0 _?=$INSTDIR' ;Do not copy the uninstaller to a temp file

Why isn't the uninstaller rebooting?

Thanks,
Gili

demiller9January 20, 2012 at 6:56 PM#

Windows 'knows' that the installer is running and prevents the reboot. I had a similar problem and solved it by making the uninstaller terminate the installer.

cowwocJanuary 20, 2012 at 7:09 PM#

Originally Posted by demiller9 View Post

Windows 'knows' that the installer is running and prevents the reboot. I had a similar problem and solved it by making the uninstaller terminate the installer.

Seems hackish, but just in case... how do you do that? 🙂
Is there a cleaner solution?

Thanks,
Gili

AndersJanuary 20, 2012 at 9:02 PM#

The installer is blocking the reboot IIRC, I think there is a plugin that prevents it from doing that...

cowwocJanuary 23, 2012 at 3:44 PM#

Originally Posted by Anders View Post

The installer is blocking the reboot IIRC, I think there is a plugin that prevents it from doing that...

Where can I find this plugin?

Afrow UKJanuary 23, 2012 at 5:34 PM#

http://nsis.sourceforge.net/ShutdownAllow_plug-in

Stu

cowwocJanuary 23, 2012 at 6:13 PM#

Excellent. Thanks Stu! 🙂

Gili

cowwocJanuary 23, 2012 at 7:01 PM#

Okay, now I've got one more problem... The uninstaller is causing the system to reboot, but in the meantime it returns control back to the installer which allows the user to begin installation.

I noticed that the uninstaller is returning exit code 164 (or -164, I forget). Where does this number come from? Is it documented somewhere? Can I rely on it not changing?

Thanks,
Gili

cowwocJanuary 23, 2012 at 7:10 PM#

Hmm, it seems I jumped the gun. I get an exit code of 164 whether the uninstaller reboots or not. Any ideas on how to tell the installer to abort when the uninstaller tries to reboot?

Afrow UKJanuary 23, 2012 at 7:12 PM#

Looking at the source it just returns the current error level (SetErrorLevel) so perhaps something in your script is setting it to 164. You can try setting your own error level just before rebooting.

Stu

cowwocJanuary 23, 2012 at 7:16 PM#

I stand corrected. I'm getting error code 0 (not 164) whether it reboots or not.

cowwocJanuary 23, 2012 at 7:17 PM#

Stu,

Which function gets executed if the user chooses to reboot (I'd like to SetErrorLevel there)? I believe the reboot flag is being set by "Delete /REBOOTOK". I never explicitly set it.

Afrow UKJanuary 23, 2012 at 7:20 PM#

IfRebootFlag 0 +2

  SetErrorLevel 99

Stu

cowwocJanuary 23, 2012 at 7:56 PM#

Originally Posted by Afrow UK View Post
IfRebootFlag 0 +2

  SetErrorLevel 99
Stu

I added this to the end of:

Section "Uninstall"

Thanks again,
Gili