Originally Posted by Anders
Why do you prefix your plugin names with ns? It might have made sense back when Nullsoft did most of the NSIS work but not really anymore IMHO.
Yes it's just a habit really now I suppose. It does make it easier to find plug-ins when searching though, and provides plug-ins with a non-generic name without adding many additional characters. What would you have named the plug-in?
Originally Posted by Anders
And you depend on msvcr110 because you use ATL ActiveX hosting? I am/was working on a plugin that hosts IE but getting the OLE details correctly when doing everything yourself is tricky.
Just referencing the IShockwaveFlash interface in the code requires some CRT initialization thanks to the compiler. The actual ATL functions (such as AtlAxAttachControl) are dynamically loaded though (which keeps the DLL size down a little).
Originally Posted by Anders
Why use HeapAlloc over GlobalAlloc? You are going to import GlobalAlloc anyway if you use the stack...
According to MSDN, GlobalAlloc and LocalAlloc are just wrappers for HeapAlloc and using them just adds additional overhead.
Edit: I see what you are saying now. Perhaps I will change it for the next version.
Stu
