Skip to content
⌘ NSIS Forum Archive

MakeNSIS Windows Wrapper - Crash

13 posts

Joost Verburg#

MakeNSIS Windows Wrapper - Crash

I've got a problem with version 0.9j of MakeNSISW. Always when I try to compile a certain project and use the wrapper, MakeNSISW crashes at the same point (when NSIS is busy with a File /r command). Without the wrapper, everything works fine.

🧟
Joost Verburg#
It crashes when I'm using the File /r command to add about 1000 files to my projects.

The content of the wrapper windows is +/- 32 kb when it crashes, maybe an overflow when there is too many text in the textbox?

Debugging:
Unhandled exception in makensisw.exe: 0xC0000005: Access Violation.
rainwater#
I've got the problem fixed now. It was a problem with the logwindow size. If you need an updated copy, just email me. Else, I will post the source shortly.

Rob
nsfis#
Rob,

could you please post newer versions of Makensisw also in binary form ? I don't have Visual C++ to create executable file.

Thanks
Joost Verburg#edited
Version 1.0 seems to works better, but it still crashes on large output sometimes.
rainwater#
Yes, I think the LogMessage function is buggered. I will try to wade through it and see what is causing the problems.
rainwater#
See if this fixes your problems. I am not able to reproduce the bug. I've tried with insane script sizes and I don't receive a crash. Make sure you compile in release mode so it will replace the current version.
Joost Verburg#
I've had no problems so far with this version. Version 1.0 crashed only once, so I'll have to test it a bit longer to be sure about it.

The script size is not the problem, but the output of MakeNSIS. If you want to do some testing, just try to add 1000 files (or even more) with the File /r command, MakeNSIS will output a line for every file:

File: "1" .... bytes
File: "2" .... bytes
File: "3" .... bytes
File: "4" .... bytes
File: "5" .... bytes
File: "6" .... bytes

etc.
rainwater#
Yes, when I said script size, I meant the size of the output that is logged. I've tried with outputs up to 84k with no problems. Hopefully the problem is really fixed now.

Rob
Joost Verburg#
Originally posted by rainwater
Yes, when I said script size, I meant the size of the output that is logged. I've tried with outputs up to 84k with no problems. Hopefully the problem is really fixed now.

Rob
Ok. 🙂 I've just compiled a lot of scripts with large output, and no problems so far... 😛