MBCS patches

I found out that if I use Korean characters in the Name property and doesn't specify the Caption, or if I use Korean chars in the InstallDir, the installer messes up the display.
Here are the patches. I want these to be accepted so that I won't have to apply the same patches every time new version is released. 🙂

diff -r -C2 src1/build.cpp src2/build.cpp
*** src1/build.cpp Wed Jul 10 12:16:52 2002
--- src2/build.cpp Thu Jul 4 11:47:46 2002
***************
*** 1268,1272 ****
char buf[1024];
wsprintf(buf,"%s Setup",build_strlist.get()+build_header.common.name_ptr);
! build_header.common.caption_ptr=add_string_main(buf,0);
}

--- 1268,1272 ----
char buf[1024];
wsprintf(buf,"%s Setup",build_strlist.get()+build_header.common.name_ptr);
! build_header.common.caption_ptr=add_string_main(buf);
}

diff -r -C2 src1/exehead/Ui.c src2/exehead/Ui.c
*** src1/exehead/Ui.c Wed Jul 10 12:17:55 2002
--- src2/exehead/Ui.c Thu Jul 4 18:10:19 2002
***************
*** 511,514 ****
--- 511,515 ----
const char *post_str;
const char *p;
+ char proc_str[NSIS_MAX_STRLEN];
IMalloc *m;
SHGetPathFromIDList( idlist, name );
***************
*** 519,523 ****
m->lpVtbl->Release(m);
}
! post_str=GetStringFromStringTab(g_inst_header->install_directory_ptr);

p=scanendslash(post_str);
--- 520,525 ----
m->lpVtbl->Release(m);
}
! process_string_fromtab(proc_str, g_inst_header->install_directory_ptr);
! post_str = proc_str;

p=scanendslash(post_str);

Why do you need to change:

build_header.common.caption_ptr=add_string_main(buf,0);

to

build_header.common.caption_ptr=add_string_main(buf);

as Sangpil Yoon, when using some french special caracters like ç é è à, these are just skiped in the title bar (using Name or Compiling makensis using french strings) !
I hope this will be corrected in the news release 🙂

-

Nevermind my previous post. I see why that is not working.

I this could be corrected, this would be a great thing for me 🙂
thanks a lot about that 👍

Try my updated version of NSIS 2.0a1 here. Let me know if this fixes the problems.

corrected in the title bar, but another bug has appear in the select directory caption !
When using
Name "Yahoo! 5 é fr"

This displays "Select the directory to install Yahoo! 5 ÿé fr in :"
😁 hey hey, still some work, but thing are better 😉