DropList limited to 999 characters?

18 posts

PrinzJanuary 8, 2003 at 9:22 PM#

DropList limited to 999 characters?

Hi,

(Nsis 2.0b1 CVS Modern UI)

I need to add 193 items into my droplist, but it doesn't show more than 999 characters, the rest has been cutted automatically. Is there a way to insert more?

Greets!

kichikJanuary 9, 2003 at 11:33 AM#

Why do you need more than 999 characters? Is that even visible on screen?

If you have a compiler you can change Contrib\InstallOptions\InstallOptions.cpp line 449 and replace 1000 with a bigger number, then recompile.
If you don't I must know why would you ever need more then 999 characters before I make that buffer larger.

PrinzJanuary 9, 2003 at 12:26 PM#

Hi,

I'd already found it in installoptions.cpp, thanks for your reply anyway.

Why do I need more than 1000 characters? 1000 seems a lot, but in fact it isn't when you need for example: "choose your country": there are 200 countries to choose from. It has about 2450 characters.

Best Regards!

kichikJanuary 9, 2003 at 12:33 PM#

Ahh... Right, I forgot that the text field needs to contain all of the entries... I thought you wanted to make a 1000+ characters long line 😁

I have updated the max to 4096 characters, that should be enough I think.

PrinzJanuary 9, 2003 at 4:27 PM#

Thanks very much! 🙂

PrinzJanuary 10, 2003 at 6:29 PM#

I've tested a little bit with the update, but the droplist is still limited to 1035 chars. (used to be 999) 🙁

I've tried to compile InstallerOptions.cpp to test with static char szResult[4096];

Very strange that it's 999 characters with a buffer of 1024 and 1035 characters with a buffer of 4096.

Do you have an idea?

kichikJanuary 10, 2003 at 8:25 PM#

Well, NSIS variables are limited to 1024 charcaters by default. Are you using one big variable to write to the INI?

PrinzJanuary 10, 2003 at 9:05 PM#

kichikJanuary 10, 2003 at 9:09 PM#

Depends on how you are writing into the INI. Do you compress it ready or do you change it using NSIS on run-time?

EDIT: OK, it doesn't either way... Let me have a look.

PrinzJanuary 10, 2003 at 9:13 PM#

It's a custom page that imports the manually created .ini I wrote before the compile. It reads that .ini when the page shows up. About compression? I don't know.

kichikJanuary 10, 2003 at 9:17 PM#

There is the problem. From wsprintf docs:

To use buffers larger than 1024 bytes, use _snwprintf. For more information, see the documentation for the C run-time library.

I will have to fix that one... I will also have to have a look everywhere wsprintf is used =/

For now replace line 585 of InstallOptions.cpp with:



strcpy(pFields[nIdx].pszListItems, szResult);

pFields[nIdx].pszListItems[nResult] = '|';

pFields[nIdx].pszListItems[nResult + 1] = '0';

PrinzJanuary 10, 2003 at 9:37 PM#

Thank you!

I'm very sorry to bother you again with another question. When trying to compile InstallerOptions.cpp I receive the following error message:

on line 290: sf->ParseDisplayName(hConfigWindow, NULL, (unsigned short *)s, &eaten, &root, NULL);

[C++ Error] InstallerOptions.cpp(290): E2342 Type mismatch in parameter 'pszDisplayName' (wanted 'wchar_t *', got 'unsigned short *')

I also inserted #define STRICT above #include <windows.h> to avoid an error on line 704

kichikJanuary 10, 2003 at 9:52 PM#

What compiler are you using? Unsigned short is wchar_t...

PrinzJanuary 10, 2003 at 9:54 PM#

Borland C++ Builder 6.0 Enterprise

kichikJanuary 10, 2003 at 9:57 PM#

Never used it...
Just change (unsigned short *) to (wchar_t *), that should make it happy.

PrinzJanuary 10, 2003 at 10:04 PM#

Well, it did make the compiler happy, but unfortunately not the NSIS compiler:

Invalid command: InstallOptions::initDialog
Error in macro MUI_INSTALLOPTIONS_INITDIALOG on macroline 8
Error in macro MUI_FUNCTIONS_WELCOMEPAGE on macroline 23
Error in macro MUI_FUNCTIONS_PAGES on macroline 9
Error in macro MUI_BASIC on macroline 9
Error in macro MUI_SYSTEM on macroline 9
Error in script "C:\Program Files\NSIS20\Examples\Modern UI\droplist.nsi" on line 79 -- aborting creation process

Could you please compile it for me so I can go on with my project?
Thanks for all your help!

(you must be tired of me now 😉 )

kichikJanuary 10, 2003 at 10:23 PM#

I am sorry I can't help you there... Seems like the compiler doesn't export IO's function or exports them under the wrong name.

I have attached a compiled version with the above change.

(you must be tired of me now 🙂)

Never 😁

PrinzJanuary 10, 2003 at 10:26 PM#

Thanks very much Kichik, this works fine!
Keep up the good NSIS work 😁